Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug on Android: Lose video controller options when click 'expand' on video subjects #393

Closed
trouille opened this issue Apr 2, 2022 · 2 comments · Fixed by #510
Closed
Labels

Comments

@trouille
Copy link
Member

trouille commented Apr 2, 2022

What the app is supposed to do:

When you click on the 'expand' button on a video subject, I would expect that the video controller options (pause, fast forward, etc.) would continue to be available.

What the app does instead:

When you click on the 'expand' button on a video subject, the video controller (pause, fast forward, etc.) goes away/is not available to click on.

Exact steps to Reproduce
Steps to reproduce the behavior:

  1. Go to Marks' https://www.zooniverse.org/lab/15140/collaborators and add yourself as collaborator
  2. open that project within 'preview' section of mobile app
  3. click 'expand' button on the video subject.
  4. Try to find the video controller.

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot_20220402-103411-582

(Note; ignore the calls&notifications will vibrate note in the screenshot -- that's just something my phone does when I take a screenshot on it - it's not something I see at other times on the screen).

(please complete the following information):

  • OS: [e.g. iOS]: Android
  • Device: (example:we once had an icon problem that only appeared on the Pixel 2): Moto g power (2021)
  • Version [e.g. 2.8.2]: Android v11

Additional context
Add any other context about the problem here.

@trouille trouille added the bug label Apr 2, 2022
@mcbouslog
Copy link
Contributor

mcbouslog commented Sep 9, 2022

I am surprised by the following, but unfortunately react-native-video has issues with video controls on Android when using the video player within a react-native Modal (as we are with the expanded view, see react-native-video/issues/2563).

I also tried to pass a ref around and use react-native-video's .presentFullscreenPlayer(), but was not successful.

Recommended additional video control packages, like react-native-video-controls or react-native-video-player have their own issues and are not well maintained.

While I couldn't get any of the noted options to work within a day or so, I think this is important functionality that should be revisited, maybe exploring the options noted more or with a new option.

@lcjohnso lcjohnso moved this to Medium Priority in Mobile Effort Oct 4, 2023
@lcjohnso lcjohnso moved this from Medium Priority to High Priority in Mobile Effort Oct 5, 2023
@lcjohnso lcjohnso moved this from High Priority to Medium Priority in Mobile Effort Oct 5, 2023
@lcjohnso lcjohnso moved this from Medium Priority to High Priority in Mobile Effort Nov 16, 2023
@coryzoon coryzoon moved this from High Priority to Underway in Mobile Effort Feb 6, 2024
@coryzoon
Copy link
Contributor

coryzoon commented Feb 8, 2024

@mcbouslog I tried a few different options but ultimately the best solution was to add the react-native-video-controls library which adds controls to the react-native-video library. When the expand button is pressed, it will use the react-native-video-controls library while in fullscreen mode. This will add the controls that are missing. This includes the ability to pause/play and adjust the time slider. Screenshot below is what it would look like on Android.

Image

@mcbouslog mcbouslog linked a pull request Feb 8, 2024 that will close this issue
@lcjohnso lcjohnso moved this from Underway to Complete in Mobile Effort Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants