fix(lib-classifier): expire classification session IDs #6504
+39
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatyourgreens
force-pushed
the
fix-session-id
branch
from
d4fabee
to
d70275b
Compare
- fix the session ID tests so that they fail properly. - fix `getSessionID` to pass the tests. - refresh the session TTL whenever an annotation is updated.
- fix `stored.ttl` so that dates are compared as `Date` objects. - refactor `generateSessionID` to return a session ID. - update tests for `generateSessionID`.
eatyourgreens
force-pushed
the
fix-session-id
branch
from
2ea1353
to
a2e4e9c
Compare
eatyourgreens
commented
Nov 28, 2024
Comment on lines
-37
to
-38
| const { authClient } = getRoot(self) | ||
| authClient?.checkBearerToken() |
There was a problem hiding this comment.
These lines are left over from when I was debugging expired auth sessions in Beyond Borders, a long time ago. I forgot to remove them when I was finished.
eatyourgreens
force-pushed
the
fix-session-id
branch
from
398a6dd
to
e01ef0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSessionIDto pass the tests, by expiring a session ID after five minutes of inactivity.generateSessionIDso that it generates a session ID.storedSession()andnewSession()methods, to make it a little clearer what the code is doing.Please request review from
@zooniverse/frontendteam or an individual member of that team.Package
Linked Issue and/or Talk Post
How to Review
All classifications made in a single session should still have the same session ID here. The difference from #6499 is that a new session ID should be generated if you do nothing for 5 minutes. It should be possible to record multiple classification sessions from a single browser session in the same tab.
Checklist
PR Creator - Please cater the checklist to fit the review needed for your code changes.
PR Reviewer - Use the checklist during your review. Each point should be checkmarked or discussed before PR approval.
General
yarn panic && yarn bootstrapordocker-compose up --buildand FEM works as expectedGeneral UX
Example Staging Project: i-fancy-cats
Bug Fix