Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom stats calendar doesn't work on a touchscreen #6418

Open
eatyourgreens opened this issue Nov 3, 2024 · 2 comments
Open

Custom stats calendar doesn't work on a touchscreen #6418

eatyourgreens opened this issue Nov 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Nov 3, 2024

Package

  • lib-user

Describe the bug

The custom calendar dialog for user stats doesn't work on a touchscreen. You can't change the date range or close the modal dialog. The only option is to reload the page.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://www.zooniverse.org/users/eatyourgreens/stats?start_date=2024-10-28
  2. Select custom date range.

Expected behavior

I should be able to select a custom date range.

Device information

Smartphone (please complete the following information):

  • Device: iPhone
  • OS: iOS
  • Browser: WebKit
  • Versio: 18

Additional context

The dialog is broken on any touchscreen device. Neither the close button, calendar, nor the Done button work.

@eatyourgreens eatyourgreens added the bug Something isn't working label Nov 3, 2024
@eatyourgreens
Copy link
Contributor Author

The custom date picker doesn't pass the cancel option to React Rnd, so the default touch action is to drag the modal popup.

See the sub task popup for an example.

const rndProps = {
cancel: '.subtaskpopup-element-that-ignores-drag-actions',
minHeight,
minWidth,
onDragStop,
onResize,
position: position || defaultPosition
}

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Nov 3, 2024

NB. the close button has a very specific class name, which isn't designed to be changed by users of the MovableModal component.

<CloseButton
className='subtaskpopup-element-that-ignores-drag-actions'
closeFn={closeFn}
color={color}
/>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant