Workflow with multiple combo tasks doesn't load

[mcbouslog]

Package

• lib-classifier

Describe the bug

A workflow with multiple combo tasks fails to load:

• lab: https://www.zooniverse.org/lab/4312/workflows/24807?femLab=true
• classify page: https://frontend.preview.zooniverse.org/projects/markbouslog/test-project-mb/classify/workflow/24807

To Reproduce

Steps to reproduce the behavior:

1. Go to workflow with multiple combo tasks FEM classify page
2. Note tasks don't load
3. Go to workflow with multiple combo task PFE classify page
4. Note tasks load

Expected behavior

Tasks load.

Additional context

With steps/pages editor this won't be an issue, can use steps/pages editor instead.

[eatyourgreens]

Workflow 24807 has a steps array, so it will ignore the combo tasks and use the steps that were added by the project builder.

[eatyourgreens]

When this happened to me, it was because projects with transcription enabled automatically add workflow.steps to all workflows.
zooniverse/Panoptes-Front-End#6585

[eatyourgreens]

I turned off the transcription task for your test project, then built a combo task workflow. This works:

• https://www.zooniverse.org/projects/markbouslog/test-project-mb/classify?reload=0&workflow=24812
• https://frontend.preview.zooniverse.org/projects/markbouslog/test-project-mb/classify/workflow/24812

This is a really annoying bug in the project builder.

[eatyourgreens]

More annoying because you can't delete workflow.steps once it's been created, except directly via the Panoptes API.

[mcbouslog]

Thanks @eatyourgreens ! Interesting and indeed frustrating.

I think I'm only seeing the first step / 2 combo tasks on https://frontend.preview.zooniverse.org/projects/markbouslog/test-project-mb/classify/workflow/24812 ? I don't see the second step / 3rd combo task and it's Done (instead of Next) on the first step.

[eatyourgreens]

Looks ok to me.

[eatyourgreens]

Oh wait, that's the wrong page. You might need to dig into the code to figure out how the next step is calculated. The next task should be set on the combo task.

[eatyourgreens]

We used combo tasks to build Engaging Crowds projects so they should just work.

[eatyourgreens]

I've gone through and explicitly set the next task for each answer.

[eatyourgreens]

Seems to be working now. I think the single question task determines the next step when you choose an answer, so that you can build branching workflows.

[mcbouslog]

Yes, that appears to have fixed it, thanks for working through this.

The impetus behind this issue is this Notes from Nature Lab workflow - https://www.zooniverse.org/lab/9485/workflows/24808. I've seen the same issue/resolution in that the question task answers in the first combo did not have a next task defined, but once I selected a next task for the question task answers, the steps/combos work as expected.

Yep the single question task answers and combo next task are conflicting somewhere in https://github.com/zooniverse/front-end-monorepo/blob/master/packages/lib-classifier/src/store/helpers/convertWorkflowToUseSteps/convertWorkflowToUseSteps.js, but it's not jumping out to me. I'll try and take a closer look during the week.

[eatyourgreens]

The questions here work for me, in mobile Safari.
https://frontend.preview.zooniverse.org/projects/md68135/notes-from-nature-labs/classify/workflow/24808