Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project app: slow build times on dynamic Classify pages #2741

Closed
eatyourgreens opened this issue Feb 2, 2022 · 2 comments
Closed

Project app: slow build times on dynamic Classify pages #2741

eatyourgreens opened this issue Feb 2, 2022 · 2 comments
Labels
bug Something isn't working performance

Comments

@eatyourgreens
Copy link
Contributor

Package

app-project

Describe the bug

Project Classify pages can take 1s or more to build on projects with workflow selection or subject set selection.

To Reproduce

On a project like HMS NHS or Davy Notebooks, go to Classify and wait for the workflow choices to load. The lag can be quite noticeable.
https://www.zooniverse.org/projects/msalmon/hms-nhs-the-nautical-health-service
https://www.zooniverse.org/projects/humphrydavy/davy-notebooks-project/

Expected behavior

Page props are only ~12k for HMS NHS, so I'd expect download times under 100ms.

Additional context

Static builds (#2531) will fix this by serving static page HTML and JSON from the CDN cache. I'd still like to investigate why getServerSideProps is taking so long to run. It could be that there are redundant network calls being run for each page request, which we can remove.

@lcjohnso
Copy link
Member

Fixed by #2531

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Jan 12, 2024

#2531 didn’t fix the page builds. getStaticProps can still take ~1s to execute. #2531 cached the page props so that getStaticProps isn’t run for every request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance
Projects
None yet
Development

No branches or pull requests

3 participants