Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject URLs should update for projects that use subject selection #2537

Open
eatyourgreens opened this issue Nov 12, 2021 · 4 comments · Fixed by #2549
Open

Subject URLs should update for projects that use subject selection #2537

eatyourgreens opened this issue Nov 12, 2021 · 4 comments · Fixed by #2549
Labels
bug Something isn't working

Comments

@eatyourgreens
Copy link
Contributor

eatyourgreens commented Nov 12, 2021

Package

app-project
lib-classifier

Describe the bug

Expected behavior

You should go back to the subject you were working on.

Additional context

You can use the Next Available Subject button to jump back to an unclassified subject, but it's not an ideal experience.

Tested in Firefox 94 on MacOS 11.6.1.

@eatyourgreens eatyourgreens added the bug Something isn't working label Nov 12, 2021
@eatyourgreens
Copy link
Contributor Author

We’ll need to be careful here that we don’t show the subject ID on workflows where knowing the ID in advance would bias the classification.

@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Nov 15, 2021

On projects that allow for Next/Previous subject navigation, you can reproduce a similar bug:

  • Use Next to go forward a few subjects.
  • Classify and go to Talk.
  • Click Back.
  • you’re now back at the subject from the page URL, not the subject that you browsed to.

@eatyourgreens
Copy link
Contributor Author

This issue is open again, since the upgrade to Next 13 broke subject IDs in page URLs (see #4977.) To reproduce:

  1. Go to https://www.zooniverse.org/projects/profdrrogerlouismartinez-davila/deciphering-secrets-unlocking-the-manuscripts-of-medieval-spain/classify/workflow/19276/subject-set/106935/subject/79594610?demo=true
  2. Submit a couple of demo classifications.
  3. Submit a classification with Done & Talk.
  4. Return to Classify with the browser Back button, and you'll be back at your original page (page 20.)

Tested in Firefox 120 on MacOS Monterey.

@eatyourgreens eatyourgreens reopened this Dec 17, 2023
@eatyourgreens
Copy link
Contributor Author

Next.js has experimental support for the History API, via experimental.windowHistorySupport, since vercel/next.js#58335. That might help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant