Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow purpose icon attribute in manifest.js #627

Closed
AmauryD opened this issue Oct 29, 2020 · 3 comments
Closed

Allow purpose icon attribute in manifest.js #627

AmauryD opened this issue Oct 29, 2020 · 3 comments

Comments

@AmauryD
Copy link

AmauryD commented Oct 29, 2020

Hello,

I get a warning message when i use the purpose attribute in icons.

My manifest.js file (simplified):

module.exports = function(/* environment, appConfig */) {
  return {
    ...
    icons: [
      ...
      {
        src: '/assets/favicons/maskable_icon.png',
        sizes: '512x512',
        type: "image/png",
        purpose: "maskable"
      }
  }
}

WARNING: manifest.webmanifest validation: Unknown icon attribute "purpose".

The property seems to be moved (at least Lighthouse is ok with it) to manifest.webmanifest but the warning message is a little confusing, purpose should be a valid attribute.

@bobisjan
Copy link
Contributor

Hi 👋,

this warning comes from web-app-manifest-validator, it looks that it is already fixed in master by san650/web-app-manifest-validator#8 😍.

I'll update and release patch version when available, until then this warning can be ignored, sorry for the confusion.

@san650
Copy link
Contributor

san650 commented Oct 30, 2020

I've released a new version of web-app-manifest-validator

@bobisjan
Copy link
Contributor

Released as v5.0.1 🚀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants