Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with hex color, missing entry #1

Open
daf opened this issue May 24, 2019 · 9 comments
Open

issues with hex color, missing entry #1

daf opened this issue May 24, 2019 · 9 comments

Comments

@daf
Copy link

daf commented May 24, 2019

Hi, two issues that pybase16-builder uncovered:

  • base0C: "5aevvc" - pybase16 chokes on trying to interpret ev as a hex color - i replaced the vv with 00 but i'm not sure what color it's supposed to be
  • won't complete due to a missing base0F entry (i used ffffff)

I put in some fake values to get it to complete and it seems fine but you'd probably have a better idea what they should be.

@belak
Copy link

belak commented May 29, 2019

I ended up using a color dropper on the base0C in the image - it looks like #5aebbc is the correct color.

In terms of a missing base0F, there's nothing that can really be done - builders should error out in this instance, but I guess they don't always do that.

@zoefiri
Copy link
Owner

zoefiri commented Jun 10, 2019

shoot sorry I hoped I fixed that real quick after pal couldn't parse it before anyone noticed and then went on vacation, thanks for making an issue on it it's fixed now.

@zoefiri zoefiri closed this as completed Jun 10, 2019
@daf
Copy link
Author

daf commented Jun 11, 2019

Thanks - it might still need a base0F entry though? Maybe that depends on which theme builder you use.

@belak
Copy link

belak commented Jun 11, 2019

Yeah, this is still missing base0F. I'd be happy to re-enable it in the schemes repo once that's fixed.

@zoefiri
Copy link
Owner

zoefiri commented Jun 12, 2019

@belak
Damnit I thought the Base16 main repo said 0F was deprecated??? Either way though sorry I'll work something in, thanks for notifying me.

@belak
Copy link

belak commented Jun 12, 2019

I think it's meant for deprecated functions, not that the color is deprecated. That's definitely not very clear.

@zoefiri zoefiri reopened this Jun 12, 2019
@amfl
Copy link

amfl commented Jul 20, 2019

Does 46415a7 close this again?

@belak
Copy link

belak commented Jul 21, 2019

I believe it does

@belak
Copy link

belak commented Mar 19, 2020

This is now resolved and can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants