fix(boards): Disable uart serial node in Xiao BLE by default #2672
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xiao_serial
node corresponds touart0
, which uses D6 and D7 pins by default on Xiaos. When logging or Studio USB snippets are used, they turn onCONFIG_SERIAL
and this prevents those pins from being used for other things, even though both use serial over USB.For RP2040 this is disabled in https://github.com/zmkfirmware/zmk/blob/main/app/boards/seeeduino_xiao_rp2040.overlay#L7, for Hummingbird shield this was disabled at the shield level but was (mistakenly?) removed in e0339a2#diff-b0c154eb8d05802c1c61671a7e9e2ca6021c2ec81127f2c57194a84d7a85cdbfL57.
Is there a reason to not disable it by default for ZMK at the board level, like this? I can't think of any. Other boards like nice!nano don't set
status = "okay";
either.Fixes #1887.
PR check-list