fix: include a header file for RC macros #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Munnich
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for tester_xiao.
To test the following article, I specified
seeeduino_xiao_bleandtester_xiaoforwest build, but adevicetree erroroccurred. This happened on Github Actions using the new zmk-config.https://zmk.dev/docs/troubleshooting/hardware-issues
The issue occurred because the RC macro was not defined, and I addressed it by adding
#include <dt-bindings/zmk/matrix_transform.h>to the.overlayfile.I would appreciate it if you could comment if there is a more appropriate solution or if there is any additional code that needs to be included.