Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Request] Rename variable name #400

Closed
wants to merge 250 commits into from
Closed

[Request] Rename variable name #400

wants to merge 250 commits into from
+32,604 −102,546

Conversation

ilyanew
Copy link
Contributor

@ilyanew ilyanew commented May 10, 2018

Rename variable 'final' to 'fin'. Because 'final' is reserved word in javascript. And it breaks down 'yui compressor'.
Please find the list of reserved words in js:
https://www.w3schools.com/js/js_reserved.asp
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar

zloirock added 30 commits May 7, 2018 23:02
@zloirock
remove Error.isError (withdrawn)
9587e0a
@zloirock
remove System.global (replaced by global)
c0ff92f
@zloirock
remove Reflect.enumerate (removed from the spec)
3d887fb
@zloirock
remove Map#toJSON and Set#toJSON (rejected)
df95421
@zloirock
remove Number#@@iterator (non-standard)
c860f7f
@zloirock
remove Object.{define, make} (non-standard)
1dd5950
@zloirock
remove delay (non-standard)
274dd1b
@zloirock
finally remove RegExp.escape (rejected -> non-standard)
20cf2a8
@zloirock
remove String#{escapeHTML, unescapeHTML} (non-standard)
d1fc47b
@zloirock
remove Object.isObject (non-standard)
48f6a9e
@zloirock
remove Object.classof (non-standard)
88cb0df
@zloirock
remove unnecessary iteration methods from CSSRuleList, MediaList,…
6729ecc 
… `StyleSheetList`
@zloirock
remove Dict (non-standard)
d6c6b68
@zloirock
remove Function#part (non-standard)
1f25860
@zloirock
remove es5 module mock
d3f8b32
@zloirock
replace es7. modules prefix to esnext., remove core-js/es7/* en…
2665ab9 
…try points
@zloirock
replace es6. modules prefix to es., remove core-js/es5/* entry …
8210c1f 
…points
@zloirock
move Array#includes to the stable ES namespace
69b0a58
@zloirock
move Object.values and Object.entries to the stable ES namespace
e0d657a
@zloirock
move Object.getOwnPropertyDescriptors to the stable ES namespace
1c82def
@zloirock
move Object#__(define|lookup)[GS]etter__ to the stable ES namespace
3887d0f
@zloirock
move String#{padStart, padEnd} to the stable ES namespace
16b6460
@zloirock
remove experimental task, tests, namespace
e141569
@zloirock
get rid of shim entries, bundles, tests
90f7930
@zloirock
get rid of library bundles in npm and git, leave it only for testing
d7f3144
@zloirock
use import of separate modules in docs of iteration helpers
3123453
@zloirock
improve examples at the top of README
239be2f
@zloirock
some improvements of README
7ea5601
@zloirock
bower should finally die
a3f1f47
@zloirock
update Array#flatten and Array#flatMap
ec856f3 
- use `isArray` instead of `isConcatSpreadable`
- set the target length explicitly
zloirock added 17 commits May 7, 2018 23:04
@zloirock
some stylistic changes
485e1c1
@zloirock
3.0.0-alpha.4
98d05b9
@zloirock
fix overriding of some modules in the pure version
bb395e4
@zloirock
use String constructor in conversion error arguments for prevent po…
2cca110 
…ssible problems with symbols
@zloirock
extract well-known symbols definition from es.symbol
85c8d10 
related babel/babel#7740
@zloirock
move Math@@toStringTag and JSON@@toStringTag to `es.symbol.to-str…
46c0773 
…ing-tag`
@zloirock
move Math@@toStringTag and JSON@@toStringTag to separate modules …
c6cd4af 
…for improving configurability
@zloirock
some stylistic changes, comments
943a13a
@zloirock
fix Promise operations order test, related Chrome 66 bug
47a58eb
@zloirock
fix v8 6.6 (Node 10 and Chrome 66) Promise bug with resolving custo…
e6f992a 
…m thenables
@zloirock
update .name properties of `String#{trimStart, trimEnd , trimLeft, …
f24b006 
…trimRight}` by proposal, mark mongolian vowel separator as non-whitespace in one more place
@zloirock
add compositeKey method from richer keys proposal
6300ba3
@zloirock
fix microtasks in WebOS, see zloirock#396
919c9ce
@zloirock
restore Node 10 in .travis.yml
2648652
@zloirock
add a comment about LG WebOS 2 Promise.resolve issue
99d12cf
@zloirock
update String#codePoints proposal per tc39/proposal-string-prototyp…
643e3b1 
…e-codepoints@673b43e
@zloirock
add compositeSymbol from richer keys proposal, see tc39/proposal-ri…
7d0f371 
…cher-keys@f64560d
@loganfsmyth
Copy link
Contributor

Not the maintainer of this project, but I'll just say that final hasn't been a reserved word since 2009 when the ES5 spec was released, so at a minimum this is still a bug with yui compressor for any modern code.

@ilyanew
Copy link
Contributor Author

ilyanew commented May 11, 2018

Yeap, You are absolutely right. 'Yui compressor' is too old :)
But if you merge this PR, 'core-js' can be easily transformed to es3. I believe that it will only a benefit for 'core-js'.

I would be really grateful!
You would have helped me out very much.

@zloirock
Copy link
Owner

Please, leave only this commit and I'll merge it.

@ilyanew
Copy link
Contributor Author

ilyanew commented May 14, 2018

There are some issues with newlines in a few files. :)
But I changed variable name only in 'modules/es6.typed.array-buffer.js' file.
Or should I create new PR?

@zloirock
Copy link
Owner

Just do git rebase -i and drop the rest commits.

@ilyanew ilyanew force-pushed the rename-variable-name branch from 3f296aa to 7d0f371 Compare May 14, 2018 10:37
@ilyanew ilyanew closed this May 14, 2018
@ilyanew
Copy link
Contributor Author

ilyanew commented May 14, 2018

Sorry, I've faced some problems with Rebasing. Therefore decided to create new PR #402

@zloirock
Copy link
Owner

Ok, thanks -)

@ilyanew ilyanew mentioned this pull request May 14, 2018
Merged
@zloirock
Copy link
Owner

I you wanna contribute to this project, you can try to improve linting settings for prevent problems like this in the future.

@ilyanew ilyanew deleted the rename-variable-name branch May 21, 2018 07:57
@dependencies dependencies bot mentioned this pull request May 28, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilyanew @loganfsmyth @zloirock