Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol.toStringTag is failing in certain edge cases #378

Closed
MylesBorins opened this issue Feb 12, 2018 · 2 comments
Closed

Symbol.toStringTag is failing in certain edge cases #378

MylesBorins opened this issue Feb 12, 2018 · 2 comments
Labels

Comments

@MylesBorins
Copy link

I'm still digging into exactly what is going on here... but the following code works in es6 environments

const TypedArrayPrototype = Object.getPrototypeOf(Uint8Array.prototype);
Object.getOwnPropertyDescriptor(TypedArrayPrototype, Symbol.toStringTag).get;

The same code fails when you attempt

delete global.Symbol;
require( "core-js" );
const TypedArrayPrototype = Object.getPrototypeOf(Uint8Array.prototype);
Object.getOwnPropertyDescriptor(TypedArrayPrototype, Symbol.toStringTag).get;

This was discovered when smoke testing Node v6.13.0. Please let me know if any other information is helpful

@zloirock
Copy link
Owner

The problem not in Symbol.toStringTag. The most part of typed arrays polyfills polyfilled without support %TypedArrayPrototype%, it's not always possible. Anyway, at this moment I'm reworking typed arrays polyfills, so I'll try to fix this issue.

@zloirock zloirock added the es6 label Feb 12, 2018
@zloirock
Copy link
Owner

Fixed in v3 branch.

@zloirock zloirock mentioned this issue Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants