Allow user to specify that built output should not export core #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, maybe it will be useful for someone else. Thanks! |
zloirock
added a commit
that referenced
this pull request
Feb 4, 2016
Allow user to specify that built output should not export core
zloirock
added a commit
that referenced
this pull request
Feb 7, 2016
|
Renamed to |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
exportCoreoption to core-js-builder that defaults to true.If set to false, the compiled output will not contain a UMD wrapper to export the core library.
In one of our projects, we're using core-js to polyfill native Promises, but the UMD wrapper here causes problems with our test runner (because we're using r.js in our test runner, and it doesn't support the anonymous define module format).
Because we're only relying on core-js to polyfill functionality into the global scope, the exported package is unneeded- so this option would allow us to not export anything.