[which-pm] [bug] Return type does not contain null

[sounisi5011]

packages/which-pm/index.d.ts

Line 1 in 6da32f0

declare function whichpm (pkgPath: string): Promise<whichpm.Result>

packages/which-pm/index.d.ts

Line 4 in 6da32f0

type Result = NPM | YARN | PNPM | Other

In this type declaration, the return type is defined as Promise<whichpm.NPM | whichpm.YARN | whichpm.PNPM | whichpm.Other>.

However, according to the actual code, this function could return null.

packages/which-pm/index.js

Line 19 in 6da32f0

return modulesExists ? { name: 'npm' } : null

Therefore, the correct return type is Promise<whichpm.NPM | whichpm.YARN | whichpm.PNPM | whichpm.Other | null>.

This type declaration should add null to the type whichpm.Result.

-   type Result = NPM | YARN | PNPM | Other
+   type Result = NPM | YARN | PNPM | Other | null

Or, should add null to the return type.

- declare function whichpm (pkgPath: string): Promise<whichpm.Result>
+ declare function whichpm (pkgPath: string): Promise<whichpm.Result | null>