Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate ark-zkey #29

Closed
2 of 3 tasks
oskarth opened this issue Nov 11, 2023 · 5 comments
Closed
2 of 3 tasks

Integrate ark-zkey #29

oskarth opened this issue Nov 11, 2023 · 5 comments

Comments

@oskarth
Copy link
Collaborator

oskarth commented Nov 11, 2023

Problem

Currently loading of zkey is too slow. This is mitigated a bit (x10) with use of ark-zkey and a new format, arkzkey.

Details

See #25

We want to integrate ark-zkey into https://github.com/oskarth/mopro/blob/main/mopro-core/src/middleware/circom/mod.rs#L60C7-L65

Then check how long it takes to initialize this from iOS

Acceptance criteria

  • Use ark-zkey
  • Instructions updated to run separate ark-zkey build step (zkey->arkzkey)
  • Initial numbers for loading zkey on device
@oskarth
Copy link
Collaborator Author

oskarth commented Nov 11, 2023

Partially integrated.

For scripting, this https://github.com/oskarth/mopro/blob/main/scripts/prepare.sh script should be updated. Probably easiest to do some minimal cargo build/run in ark-zkey that takes zkey and spits out arkzkey in same folder, e.g. cargo run <path-to-keccak256.zkey> or similar

@oskarth
Copy link
Collaborator Author

oskarth commented Nov 11, 2023

@oskarth
Copy link
Collaborator Author

oskarth commented Dec 6, 2023

@oskarth
Copy link
Collaborator Author

oskarth commented Dec 6, 2023

Integrated into prepare script here: https://github.com/oskarth/mopro/blob/main/scripts/prepare.sh#L113

Should work hopefully! For CI still want to use from server because faster.

@oskarth
Copy link
Collaborator Author

oskarth commented Feb 23, 2024

I would say this has been done and can be closed

@oskarth oskarth closed this as completed Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant