CI: Modernise workflow #13
str4dAnnotations
30 errors and 2 warnings
|
Clippy (beta)
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L890
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:890:5
|
890 | / assert_eq!(
891 | | bool::from(
892 | | Fp2 {
893 | | c0: P_M1_OVER2,
... |
898 | | true
899 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L880
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:880:5
|
880 | / assert_eq!(
881 | | bool::from(
882 | | Fp2 {
883 | | c0: p_p1_over2,
... |
888 | | false
889 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L870
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:870:5
|
870 | / assert_eq!(
871 | | bool::from(
872 | | Fp2 {
873 | | c0: -Fp::one(),
... |
878 | | false
879 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L860
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:860:5
|
860 | / assert_eq!(
861 | | bool::from(
862 | | Fp2 {
863 | | c0: -Fp::one(),
... |
868 | | false
869 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L850
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:850:5
|
850 | / assert_eq!(
851 | | bool::from(
852 | | Fp2 {
853 | | c0: -Fp::one(),
... |
858 | | false
859 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L839
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:839:5
|
839 | / assert_eq!(
840 | | bool::from(
841 | | Fp2 {
842 | | c0: p_p1_over2,
... |
847 | | false
848 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L829
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:829:5
|
829 | / assert_eq!(
830 | | bool::from(
831 | | Fp2 {
832 | | c0: P_M1_OVER2,
... |
837 | | true
838 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L819
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:819:5
|
819 | / assert_eq!(
820 | | bool::from(
821 | | Fp2 {
822 | | c0: Fp::zero(),
... |
827 | | false
828 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L809
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:809:5
|
809 | / assert_eq!(
810 | | bool::from(
811 | | Fp2 {
812 | | c0: p_p1_over2,
... |
817 | | false
818 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L799
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:799:5
|
799 | / assert_eq!(
800 | | bool::from(
801 | | Fp2 {
802 | | c0: P_M1_OVER2,
... |
807 | | true
808 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L788
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:788:5
|
788 | / assert_eq!(
789 | | bool::from(
790 | | Fp2 {
791 | | c0: Fp::one(),
... |
796 | | true
797 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L778
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:778:5
|
778 | / assert_eq!(
779 | | bool::from(
780 | | Fp2 {
781 | | c0: Fp::zero(),
... |
786 | | false
787 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L768
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:768:5
|
768 | / assert_eq!(
769 | | bool::from(
770 | | Fp2 {
771 | | c0: p_p1_over2,
... |
776 | | false
777 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L758
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:758:5
|
758 | / assert_eq!(
759 | | bool::from(
760 | | Fp2 {
761 | | c0: p_p1_over2,
... |
766 | | false
767 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L746
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:746:5
|
746 | / assert_eq!(
747 | | bool::from(
748 | | Fp2 {
749 | | c0: Fp::one(),
... |
754 | | true
755 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L736
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:736:5
|
736 | / assert_eq!(
737 | | bool::from(
738 | | Fp2 {
739 | | c0: Fp::zero(),
... |
744 | | true
745 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L726
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:726:5
|
726 | / assert_eq!(
727 | | bool::from(
728 | | Fp2 {
729 | | c0: P_M1_OVER2,
... |
734 | | true
735 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L716
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:716:5
|
716 | / assert_eq!(
717 | | bool::from(
718 | | Fp2 {
719 | | c0: P_M1_OVER2,
... |
724 | | true
725 | | );
| |______^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L715
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:715:5
|
715 | assert_eq!(bool::from(Fp2::one().sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g2.rs#L714
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g2.rs:714:5
|
714 | assert_eq!(bool::from(Fp2::zero().sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L953
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:953:5
|
953 | assert_eq!(bool::from(p_p1_over2.sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L950
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:950:5
|
950 | assert_eq!(bool::from(P_M1_OVER2.sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L949
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:949:5
|
949 | assert_eq!(bool::from((-Fp::zero()).sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L948
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:948:5
|
948 | assert_eq!(bool::from((-Fp::one()).sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L947
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:947:5
|
947 | assert_eq!(bool::from(Fp::one().sgn0()), true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
used `assert_eq!` with a literal bool:
src/hash_to_curve/map_g1.rs#L946
error: used `assert_eq!` with a literal bool
--> src/hash_to_curve/map_g1.rs:946:5
|
946 | assert_eq!(bool::from(Fp::zero().sgn0()), false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `assert!(..)`
|
= note: `-D clippy::bool-assert-comparison` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
|
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
131 | let a = G2Projective::generator();
| ^
132 | let a_affine = G2Affine::generator();
133 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
136 | let v = vec![G2Projective::generator(); N];
| ^
137 | let mut q = vec![G2Affine::identity(); N];
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
62 | let a = G1Projective::generator();
| ^
63 | let a_affine = G1Affine::generator();
64 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
67 | let v = vec![G1Projective::generator(); N];
| ^
68 | let mut q = vec![G1Affine::identity(); N];
| ^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
|
5 bindings with single-character names in scope:
benches/groups.rs#L9
error: 5 bindings with single-character names in scope
--> benches/groups.rs:9:24
|
9 | fn criterion_benchmark(c: &mut Criterion) {
| ^
...
62 | let a = G1Projective::generator();
| ^
63 | let a_affine = G1Affine::generator();
64 | let s = Scalar::from_raw([1, 2, 3, 4]);
| ^
...
67 | let v = vec![G1Projective::generator(); N];
| ^
68 | let mut q = vec![G1Affine::identity(); N];
| ^
|
= note: `-D clippy::many-single-char-names` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
|
|
Clippy (beta)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Clippy (beta)
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|