fix(git): fix .git exclusion, set mtime = 0 to make tarballs idempotent

zkat · Apr 10, 2017 · 9a9fa1b · 9a9fa1b
1 parent 9f1f47c
commit 9a9fa1b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/handlers/git/tarball.js b/lib/handlers/git/tarball.js
@@ -85,9 +85,10 @@ function packDir (spec, label, tmp, target, opts) {
   : tar.pack(tmp, {
     map: header => {
       header.name = 'package/' + header.name
+      header.mtime = 0 // make tarballs idempotent
     },
     ignore: (name) => {
-      name.match(/\.git/)
+      return name.match(/\.git/)
     }
   })
 

diff --git a/lib/registry/manifest.js b/lib/registry/manifest.js
@@ -53,7 +53,7 @@ function manifest (spec, opts) {
       err.code = 'ENOTARBALL'
       err.manifest = manifest
       if (!manifest._warnings) { manifest._warnings = [] }
-      manifest._warnings.push(err)
+      manifest._warnings.push(err.message)
       manifest._resolved =
       `${registry}/${manifest.name}/-/${manifest.name}-${manifest.version}.tgz`
     }