Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken file based url #250

Closed
skbolton opened this issue Aug 25, 2022 · 2 comments · Fixed by #391
Closed

Broken file based url #250

skbolton opened this issue Aug 25, 2022 · 2 comments · Fixed by #391
Assignees
Labels
bug Something isn't working

Comments

@skbolton
Copy link
Contributor

I am getting this diagnostic error from zk lsp in my notes for links to files. Here is an example of a link causing the issue.

[sample](file:///home/skbolton/Documents/Notes/sample.pdf)

If I use my terminal's functionality to go to the link under the cursor it opens the file just fine. If I change the format to:

[sample](file://home/skbolton/Documents/Notes/sample.pdf) zk no longer complains about it not finding the file but my terminal will no longer open the file.

From what I gather the file:/// is the proper syntax for a file link on the current host and so it would be nice to have that working if possible so that I don't get an error in zk and my terminal properly visits the link.

I am temporarily getting around this by doing the link as [sample](file://localhost/home/skbolton/Documents/Notes/sample.pdf) which is working for both systems (its just verbose).

@mickael-menu mickael-menu added the bug Something isn't working label Sep 4, 2022
@mickael-menu
Copy link
Member

Agreed, this kind of hrefs should be ignored by zk.

@tjex
Copy link
Member

tjex commented Jan 11, 2024

Confirmed this is still happening, could potentially be looked at together with #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants