[Help] Note link autocompletion

[fmorroni]

Verify

• I searched the existing discussions for help

How can we help you?

Hi, I used to be able to get note links autocompletion by writing [link text](()) where the note suggestions would appear inside the double parenthesis, and a pair of parenthesis would disappear when I chose a note to link to. This stopped working a while ago, probably (though not sure) when I updated to neovim 0.10.
Was this feature removed or is this a bug or a problem with my config (I didn't change anything from my config since updating though).
Autocompletion is still working by using double square brackets, but that sets the link text to the note's title, and the other way lets me set custom text (which I want most of the time). Of course I can just go back and change the text afterwards, but it's pretty bothersome.

[tjex]

Hello. I just checked on my end and I'm still getting completions. You're sure nothing's changed with your `cmp` setup? There was a PR addressing a bug with completion: zk-org/zk#397 But as mentioned, it's still working on my end. In your little code example you've written `[link](())`, i.e, placed a parentheses inside a parentheses. This won't return any files as the second parentheses is what `cmp` will use as completion. It should look like this sequence `[link](` <- at this point, you should start to see completion popup.

[fmorroni]

However I don't think the double parenthesis completion you mentioned @fmorroni was ever part of zk. Maybe it was in another plugin you used?

Hmm I guess if no one else remembers using double parenthesis it could have been another plugin on my side. But I have no clue what other plugin could have caused that, and I don't think I ever had another markdown language server besides the cli zk-ls.
And could an external ls know about the zk notebook structure anyways? Because I was receiving the exact same auto-completions using double parenthesis than using double square brackets. It seems very odd to me that it would be a result of another plugin/ls.

In any case, thanks to both of you for your time.
If I find the time I may try to test the double parenthesis on an older version and a minimal config to check if they worked then.

[mickael-menu]

Actually you're right! I totally forgot I implemented this:

https://github.com/zk-org/zk/blob/725126575d00130c2fa423d36c89f0fff328a318/internal/adapter/lsp/server.go#L664-L665

And it does seem to be broken, I can't trigger it either with Nvim 0.10.0 and zk 0.14.1.

ahhhhhh. I see now. But, then there's a bug. Or something odd is going on with my setup.
As when I select a completion option on any note that isn't from the initial completion list (i.e, after filtering), it still formats as wikilink, despite having link-format = "markdown"

Are you using the LSP completion or a Neovim command like ZkInsertLink?

Unfortunately the LSP server is not covered by automated tests, so regressions are easy.

[tjex]

I'm using lsp completion via nvim-cmp. ZkInsetLink works as expected.

And it does seem to be broken, I can't trigger it either with Nvim 0.10.0 and zk 0.14.1.

Alright, then something we need to look into for sure. As mentioned, we did address something similar, but it seems to be a larger issue at hand: zk-org/zk#397

I'm also on that version combo.

[fmorroni]

Actually you're right! I totally forgot I implemented this:

https://github.com/zk-org/zk/blob/725126575d00130c2fa423d36c89f0fff328a318/internal/adapter/lsp/server.go#L664-L665

Okay after looking at this code it occurred to me to try the exact pattern shown in the code, and it actually works... If I use ](( I get autocompletions. If I use [](( I also get autocompletions. It's only when I add the link text like this [text](( that it stops working.

Not sure if this is intended but I definitely could add any custom link text before updating.

It's also kinda buggy leaving the extra parenthesis after accepting an autocompletion:

[mickael-menu]

I confirm that it's supposed to work with [title]((, this was the intended use case.

[tjex]

Reported:

Markdown link completion:
zk-org/zk#435

Incorrect link format insertion after cmp selection:
zk-org/zk#436