You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found a issue on sample app, which sometimes fail to load previous page on 7days and ScrollType Page Scroll.
I recorded movie below.
and my environment is
iPhone X(iOS 12.1.2)
repo sample app
my app settings
I checked source code and found in loadPagePageScroll method,
currentOffset is not zero (0.333333333) on 7days and do nothing.
(other days are always 0 and loadPrevPage)
private func loadPagePageScroll() {
let maximumOffset = collectionView.contentSize.width - collectionView.frame.width
// currentOffset sometimes 0.3333333333333333
let currentOffset = collectionView.contentOffset.x
if maximumOffset <= currentOffset {
loadNextOrPrevPage(isNext: true)
}
if currentOffset <= 0 {
loadNextOrPrevPage(isNext: false)
}
}
It works fine with dirty hack changing
currentOffset <= 1
but it looks other original cause currentOffset is not zero on 7days only.
I couldn't find it by myself, and very glad to help or fix this bug 👍
thanks,
The text was updated successfully, but these errors were encountered:
I find that this issue not only happened in 7days but also in other views and even for loadNextPage, which means changing currentOffset cannot solve this problem.
I think some previous updates might cause this issue and I will fix it as soon as possible.
I know it is already 4 months later, but I finally resolve this issue with 0.7.0 version released. It is actually a quite major and difficult problem for the pagination.
Hi, thanks for making awesome library 😄
I found a issue on sample app, which sometimes fail to load previous page on 7days and ScrollType Page Scroll.
I recorded movie below.
and my environment is
I checked source code and found in loadPagePageScroll method,
currentOffset is not zero (0.333333333) on 7days and do nothing.
(other days are always 0 and loadPrevPage)
It works fine with dirty hack changing
but it looks other original cause currentOffset is not zero on 7days only.
I couldn't find it by myself, and very glad to help or fix this bug 👍
thanks,
The text was updated successfully, but these errors were encountered: