Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI that builds all examples on Linux #15

Closed
knatten opened this issue Aug 16, 2019 · 4 comments
Closed

Set up CI that builds all examples on Linux #15

knatten opened this issue Aug 16, 2019 · 4 comments

Comments

@knatten
Copy link
Contributor

knatten commented Aug 16, 2019

Refer to https://github.com/zivid/zivid-python and do it the same way

@nedrebo
Copy link

nedrebo commented Aug 17, 2019

Zivid officially support Ubuntu 16.04 and 18.04, both those should be covered.

However, the additional distributions tested against in zivid-python is probably overkill and for this and will only result in maintenance overhead.

@knatten
Copy link
Contributor Author

knatten commented Sep 17, 2019

It's probably a good idea to also check that samples with missing dependencies build when the dependency is turned off. For instance setting OpenCV_DIR to a non existing directory and USE_OPENCV=OFF should work.
This will reveal if we add a sample to CMakeLists.txt without adding it to the proper dependency lists.

(Idea came from #23 (comment))

@knatten
Copy link
Contributor Author

knatten commented Sep 18, 2019

Should build on both Ubuntu 18.04 and 16.04.

@knatten
Copy link
Contributor Author

knatten commented Nov 29, 2019

We're building on Linux in CI. I've added #42 and #43 to improve further.

@knatten knatten closed this as completed Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants