diff --git a/Cargo.toml b/Cargo.toml index 8c260464b..72c81dff9 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -62,7 +62,7 @@ walkdir = "2.5.0" time = { workspace = true, features = ["formatting", "macros"] } anyhow = "1" clap = { version = "=4.4.18", features = ["derive"] } -tempdir = "0.3.7" +tempfile = "3" [features] aes-crypto = ["aes", "constant_time_eq", "hmac", "pbkdf2", "sha1", "rand", "zeroize"] diff --git a/benches/read_metadata.rs b/benches/read_metadata.rs index 73f2b26ed..1dd4456ca 100644 --- a/benches/read_metadata.rs +++ b/benches/read_metadata.rs @@ -5,7 +5,7 @@ use std::io::{self, prelude::*, Cursor}; use bencher::Bencher; use getrandom::getrandom; -use tempdir::TempDir; +use tempfile::TempDir; use zip::write::SimpleFileOptions; use zip::{result::ZipResult, CompressionMethod, ZipArchive, ZipWriter}; @@ -102,7 +102,7 @@ fn parse_stream_archive(bench: &mut Bencher) { let bytes = generate_random_archive(STREAM_ZIP_ENTRIES, STREAM_FILE_SIZE).unwrap(); /* Write to a temporary file path to incur some filesystem overhead from repeated reads */ - let dir = TempDir::new("stream-bench").unwrap(); + let dir = TempDir::with_prefix("stream-bench").unwrap(); let out = dir.path().join("bench-out.zip"); fs::write(&out, &bytes).unwrap(); @@ -116,11 +116,27 @@ fn parse_stream_archive(bench: &mut Bencher) { bench.bytes = bytes.len() as u64; } +fn parse_large_non_zip(bench: &mut Bencher) { + const FILE_SIZE: usize = 17_000_000; + + // Create a large file that doesn't have a zip header (generating random data _might_ make a zip magic + // number somewhere which is _not_ what we're trying to test). + let dir = TempDir::with_prefix("large-non-zip-bench").unwrap(); + let file = dir.path().join("zeros"); + let buf = vec![0u8; FILE_SIZE]; + fs::write(&file, &buf).unwrap(); + + bench.iter(|| { + assert!(zip::ZipArchive::new(std::fs::File::open(&file).unwrap()).is_err()); + }) +} + benchmark_group!( benches, read_metadata, parse_archive_with_comment, parse_zip64_archive_with_comment, parse_stream_archive, + parse_large_non_zip, ); benchmark_main!(benches); diff --git a/src/read.rs b/src/read.rs index 354d80702..9e0d27010 100644 --- a/src/read.rs +++ b/src/read.rs @@ -1777,7 +1777,7 @@ mod test { use crate::CompressionMethod::Stored; use crate::{ZipArchive, ZipWriter}; use std::io::{Cursor, Read, Write}; - use tempdir::TempDir; + use tempfile::TempDir; #[test] fn invalid_offset() { @@ -1979,7 +1979,7 @@ mod test { v.extend_from_slice(include_bytes!("../tests/data/symlink.zip")); let mut reader = ZipArchive::new(Cursor::new(v)).unwrap(); assert!(reader.by_index(0).unwrap().is_symlink()); - let tempdir = TempDir::new("test_is_symlink")?; + let tempdir = TempDir::with_prefix("test_is_symlink")?; reader.extract(&tempdir).unwrap(); assert!(tempdir.path().join("bar").is_symlink()); Ok(()) diff --git a/src/spec.rs b/src/spec.rs index 1dfb4e5e7..0bd89a9a7 100755 --- a/src/spec.rs +++ b/src/spec.rs @@ -353,9 +353,16 @@ impl Zip32CentralDirectoryEnd { return Err(ZipError::InvalidArchive("Invalid zip header")); } - let search_lower_bound = 0; - - const END_WINDOW_SIZE: usize = 512; + // The End Of Central Directory Record should be the last thing in + // the file and so searching the last 65557 bytes of the file should + // be enough. However, not all zips are well-formed and other + // programs may consume zips with extra junk at the end without + // error, so we go back 128K to be compatible with them. 128K is + // arbitrary, but it matches what Info-Zip does. + const EOCDR_SEARCH_SIZE: u64 = 128 * 1024; + let search_lower_bound = file_length.saturating_sub(EOCDR_SEARCH_SIZE); + + const END_WINDOW_SIZE: usize = 8192; /* TODO: use static_assertions!() */ debug_assert!(END_WINDOW_SIZE > mem::size_of::()); diff --git a/tests/extract_symlink.rs b/tests/extract_symlink.rs index 7135df50b..a53504ba6 100644 --- a/tests/extract_symlink.rs +++ b/tests/extract_symlink.rs @@ -2,13 +2,13 @@ #[cfg(all(unix, feature = "_deflate-any"))] fn extract_should_respect_links() { use std::{fs, io, path::PathBuf, str::FromStr}; - use tempdir::TempDir; + use tempfile::TempDir; use zip::ZipArchive; let mut v = Vec::new(); v.extend_from_slice(include_bytes!("data/pandoc_soft_links.zip")); let mut archive = ZipArchive::new(io::Cursor::new(v)).expect("couldn't open test zip file"); - let temp_dir = TempDir::new("pandoc_soft_links").unwrap(); + let temp_dir = TempDir::with_prefix("pandoc_soft_links").unwrap(); archive.extract(&temp_dir).unwrap(); let symlink_path = temp_dir.path().join("pandoc-3.2-arm64/bin/pandoc-lua"); diff --git a/tests/repro_old423.rs b/tests/repro_old423.rs index 83adf950b..f87245e5b 100644 --- a/tests/repro_old423.rs +++ b/tests/repro_old423.rs @@ -2,11 +2,11 @@ #[test] fn repro_old423() -> zip::result::ZipResult<()> { use std::io; - use tempdir::TempDir; + use tempfile::TempDir; use zip::ZipArchive; let mut v = Vec::new(); v.extend_from_slice(include_bytes!("data/lin-ub_iwd-v11.zip")); let mut archive = ZipArchive::new(io::Cursor::new(v)).expect("couldn't open test zip file"); - archive.extract(TempDir::new("repro_old423")?) + archive.extract(TempDir::with_prefix("repro_old423")?) }