This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
Implement ZipWriter::new_streaming for unseekable writers #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
~8 months old, project doesn't build on 1.64 anyway: > error: package `time v0.3.23` cannot be built because it requires rustc 1.65.0 or newer, while the currently active rustc version is 1.64.0
|
Thanks a lot for implementing this! I've been testing it quite a bit and it's been working very well. I only found a single issue where a panic occurs with the streaming ZipWriter when a non-zip64 small file entry is written such that the local header offset is >=2^32. I fixed it with: chenxiaolong@989101f. |
The zip spec allows non-zip64 local headers to be written at offset >=2^32 as long as the corresponding central directory entry has a zip64 extra field for the local header offset. However, when writing a non-zip64 small file after the 2^32 boundary, `local_header_size()` would return a zip64 size while writing a non-zip64 local header to disk. This would cause `self.stats.start` to get out of sync, leading to a panic in `finish_file()` when doing a checked subtraction for `self.compressed_size`. This would only manifest when performing streaming writes. This commit fixes the problem by updating `local_header_size()` to use a new `zip64_sizes()` method that only considers the compressed and uncompressed size fields since only those two matter for determining the size of a local header. Signed-off-by: Andrew Gunnerson <[email protected]>
|
This repo is no longer maintained. Could you please rebase this against https://github.com/zip-rs/zip2 and reopen it there? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a revival of #114 to implement unseekable writing via data descriptors.
No public API is changed except for the addition of
ZipWriter::new_streaming, and all adjacent functionality still works - zip64, extra data, ZipCrypto encryption. I even fixed a bug where encryption was broken if used together with extra data :).