Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support tuple tags on dotty 0.26.0-RC1 #38

Closed
neko-kai opened this issue May 29, 2020 · 9 comments
Closed

Support tuple tags on dotty 0.26.0-RC1 #38

neko-kai opened this issue May 29, 2020 · 9 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@neko-kai
Copy link
Member

Getting an exception when trying to access definition tree of Tuple.

Error:(12, 10) Exception occurred while executing macro expansion.
java.lang.AssertionError: assertion failed
	at dotty.DottyPredef$.assertFail(DottyPredef.scala:16)
	at dotty.tools.dotc.ast.tpd$.polyDefDef(tpd.scala:239)
	at dotty.tools.dotc.ast.tpd$.DefDef(tpd.scala:225)
	at dotty.tools.dotc.ast.tpd$.DefDef(tpd.scala:222)
	at dotty.tools.dotc.tastyreflect.FromSymbol$.classDef(FromSymbol.scala:33)
	at dotty.tools.dotc.tastyreflect.FromSymbol$.definitionFromSym(FromSymbol.scala:16)
	at dotty.tools.dotc.tastyreflect.ReflectionCompilerInterface.Symbol_tree(ReflectionCompilerInterface.scala:1672)
	at dotty.tools.dotc.tastyreflect.ReflectionCompilerInterface.Symbol_tree(ReflectionCompilerInterface.scala:1671)
	at scala.tasty.Reflection$SymbolOps$.tree(Reflection.scala:2161)
	at izumi.reflect.dottyreflection.Inspector.inspectTType(DbInspector.scala:55)
	at izumi.reflect.dottyreflection.Inspector.inspectTree(DbInspector.scala:121)
	at izumi.reflect.dottyreflection.Inspector.buildTypeRef(DbInspector.scala:42)
	at izumi.reflect.dottyreflection.TypeInspections$.apply(DbInspector.scala:265)
	at izumi.reflect.dottyreflection.Inspect$.inspectAny(DbInspector.scala:21)
  inspect[(Double, Double)]
@DamianReeves
Copy link

Have you had a chance to look into this? This seems to be blocking the dotty upgrade for ZIO.

@pshirshov
Copy link
Member

Not yet, will try to look at that this weekend.

@neko-kai
Copy link
Member Author

@DamianReeves This is an upstream bug without a straightforward way to work around it seems, unless we can find a way to totally omit inspecting trees, which with the current tasty-reflect I think we cannot (/cc @pshirshov).
I've posted a reproduction upstream - scala/scala3#9206

@neko-kai
Copy link
Member Author

Upstream issue was closed - scala/scala3#9206 (comment) - need to try again with latest nightly

@neko-kai neko-kai changed the title Support tuple tags on dotty 0.24.0-RC1 Support tuple tags on dotty 0.26.0-RC1 Jul 30, 2020
@neko-kai
Copy link
Member Author

There's a new dotty release with the fix merged, 0.26.0-RC1: https://dotty.epfl.ch/blog/2020/07/27/26th-dotty-milestone-release.html
should be able to restart publishing for 0.26+ now

@neko-kai neko-kai added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 30, 2020
@adamgfraser
Copy link
Contributor

@neko-kai Any change we could get a release with this fix so we could publish for the latest Dotty version when we do the ZIO 1.0 release on Monday?

@neko-kai
Copy link
Member Author

Closed by #56

@neko-kai
Copy link
Member Author

@adamgfraser Seems like it. Please check version 1.0.0-M5 for dotty 0.26.0-RC1

@adamgfraser
Copy link
Contributor

@neko-kai Great! Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants