Add an option to quiet the informational messages. #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #191 +/- ##
=========================================
+ Coverage 96.77% 96.8% +0.03%
=========================================
Files 28 28
Lines 744 751 +7
=========================================
+ Hits 720 727 +7
Misses 24 24
Continue to review full report at Codecov.
|
|
@darrinholst, could you post a screenshot of an example? It would be cool to compare with #97 :) |
|
without --quiet: with --quiet |
astorije
reviewed
Mar 15, 2018
test/integration/cli/quiet.test.js
Outdated
| it('does not show info messages', function (done) { | ||
| exec(`node ${binPath} --quiet "${test}"`, (err, stdout) => { | ||
| assert.isNull(err); | ||
| assert.notInclude(stdout, 'WEBPACK'); |
There was a problem hiding this comment.
Maybe add an assert.include(stdout, 'passing'); or something like this to ensure output is not completely empty and contains the expected output?
|
Makes sense. Thank you for this! |
This was referenced Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new messages from #97 can be a little distracting when you're used to just the output from mocha. This just adds a
--quietoption to stop showing those messages and return to the output behavior pre 1.0.I'm open to other implementations...would just like the option to opt out of them.