Expose bodyBytes from http.response in client.dart

[ifndefdeadmau5]

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

It seems response from server sometimes(in my case, request to apollo-server) isn't decoded properly by http package. So I want to manually decode raw bodyBytes by myself with my own decoding method. Currently client.query only expose that already decoded result as far as I know.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Expose bodyBytes to user.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Couldn't come up with any, yet.

Additional context
Add any other context or screenshots about the feature request here.

Below is just motivation of this feature request, which is unexpected decoding when requesting with 'content-type': 'application/json, charset=utf-8;' from client, 'Content-Type': 'application/json' from server.

and guess this is a related issue dart-lang/http#175

[dennisschneider]

I have exactly the same issue (in my case request to apollo-server-micro), being able to access bodyBytes would be nice.

[ifndefdeadmau5]

@dennisschneider Glad to found another victim here. Are you still having that issue?
I resolved that by setting server response header as 'Content-Type': 'application/json; charset=utf-8' so that dart/http can choose the right encoding

[dennisschneider]

@ifndefdeadmau5 tried it but that breaks my GraphQL Playground ... will fiddle around with it some more, thank you!

[dennisschneider]

@ifndefdeadmau5 how did you set the server response header for apollo-server & which implementation are you using ? Tried it with apollo-server-micro & apollo-server-express but apollo seems to override it ... I tried this:
app.use((req, res, next) => { res.append("Content-Type", "application/json; charset=utf-8"); next(); });

[ifndefdeadmau5]

@dennisschneider You're right. I'm using koa implementation and apollo-server forces to set 'Content-Type' to 'application/json' in response header internally. So I was able to set that by modifying package itself, but that is definitely not a clean way to do it.. so still not resolved actually 😭

[dennisschneider]

@ifndefdeadmau5 finally found a workaround ... I use http-proxy to override the header ... only drawback is that it breaks graphql-playground (but you still can connect with a standalone graphql-playground so not a real issue)

const httpProxy = require("http-proxy");

const proxy = httpProxy
  .createProxyServer({ target: "http://localhost:3000", changeOrigin: true })
  .listen(8000);

proxy.on("proxyRes", function(proxyRes, req, res, options) {
  proxyRes.headers["Content-Type"] = "application/json; charset=UTF-8";
});

[ifndefdeadmau5]

Thank you @dennisschneider, it works like a charm 👍
Hope apollo-server provide built-in way to do it soon, tho :)

[micimize]

This seems outdated - I think today this could be resolved with a custom http link, which I think is fine given the niche nature of it