feat(graphql): PersistedQueriesLink migration #699
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @micimize for letting me know, I will take a look at it asap (most likely this weekend) |
|
@kl4n4 thanks! To test in your project you'll probably need these dependency overrides: dependency_overrides:
gql_link:
git:
url: [email protected]:micimize/gql.git
ref: apq_changes
path: links/gql_link
gql_http_link:
git:
url: [email protected]:micimize/gql.git
ref: apq_changes
path: links/gql_http_link |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
v4basedPersistedQueriesLinkleveraging changes in gql-dart/gql#123While i have a vague sense of what this code does, I mostly just focused on getting the tests to pass. I'm also not sure where exactly this link belongs (in core, as a standalone
gqllink, or as an independent project. Anyhow, will prob come back and triage more after thegqlPR is refined/merged.Tagging @kl4n4 and @wwwdata as the main possible stakeholders.