fix(client): skip cache writes on null data, thus fixing #405

zino-hofmann · Nov 6, 2020 · 7472bb9 · 7472bb9
1 parent ee64e99
commit 7472bb9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/graphql/lib/src/core/_query_write_handling.dart b/packages/graphql/lib/src/core/_query_write_handling.dart
@@ -49,14 +49,18 @@ extension InternalQueryWriteHandling on QueryManager {
   /// Part of [InternalQueryWriteHandling], and not exposed outside the
   /// library.
   ///
+  /// If we have no data, we skip caching, thus taking [ErrorPolicy.none]
+  /// into account
+  ///
   /// networked wrapper for [_writeQueryOrSetExceptionOnQueryResult]
+  /// NOTE: mapFetchResultToQueryResult must be called beforehand
   bool attemptCacheWriteFromResponse(
     FetchPolicy fetchPolicy,
     Request request,
     Response response,
     QueryResult queryResult,
   ) =>
-      (fetchPolicy == FetchPolicy.noCache || response.data == null)
+      (fetchPolicy == FetchPolicy.noCache || queryResult.data == null)
           ? false
           : _writeQueryOrSetExceptionOnQueryResult(
               request,