fix(graphql): default-yet-overrideable variable

zino-hofmann · Jun 1, 2020 · 6ba687e · 6ba687e
1 parent 3246394
commit 6ba687e
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 17 deletions.
diff --git a/packages/graphql/lib/src/core/_base_options.dart b/packages/graphql/lib/src/core/_base_options.dart
@@ -11,8 +11,8 @@ import 'package:graphql/src/core/policies.dart';
 abstract class BaseOptions extends MutableDataClass {
   BaseOptions({
     @required this.document,
+    this.variables = const {},
     this.operationName,
-    this.variables,
     Context context,
     FetchPolicy fetchPolicy,
     ErrorPolicy errorPolicy,

diff --git a/packages/graphql/lib/src/core/mutation_options.dart b/packages/graphql/lib/src/core/mutation_options.dart
@@ -22,7 +22,7 @@ class MutationOptions extends BaseOptions {
   MutationOptions({
     @required DocumentNode document,
     String operationName,
-    Map<String, dynamic> variables,
+    Map<String, dynamic> variables = const {},
     FetchPolicy fetchPolicy,
     ErrorPolicy errorPolicy,
     Context context,

diff --git a/packages/graphql/lib/src/core/query_options.dart b/packages/graphql/lib/src/core/query_options.dart
@@ -12,7 +12,7 @@ class QueryOptions extends BaseOptions {
   QueryOptions({
     @required DocumentNode document,
     String operationName,
-    Map<String, dynamic> variables,
+    Map<String, dynamic> variables = const {},
     FetchPolicy fetchPolicy,
     ErrorPolicy errorPolicy,
     Object optimisticResult,
@@ -52,7 +52,7 @@ class SubscriptionOptions extends BaseOptions {
   SubscriptionOptions({
     @required DocumentNode document,
     String operationName,
-    Map<String, dynamic> variables,
+    Map<String, dynamic> variables = const {},
     FetchPolicy fetchPolicy,
     ErrorPolicy errorPolicy,
     Object optimisticResult,
@@ -75,7 +75,7 @@ class WatchQueryOptions extends QueryOptions {
   WatchQueryOptions({
     @required DocumentNode document,
     String operationName,
-    Map<String, dynamic> variables,
+    Map<String, dynamic> variables = const {},
     FetchPolicy fetchPolicy,
     ErrorPolicy errorPolicy,
     Object optimisticResult,
@@ -124,7 +124,7 @@ class WatchQueryOptions extends QueryOptions {
 class FetchMoreOptions {
   FetchMoreOptions({
     this.document,
-    this.variables = const <String, dynamic>{},
+    this.variables = const {},
     @required this.updateQuery,
   }) : assert(updateQuery != null);
 

diff --git a/packages/graphql/pubspec.yaml b/packages/graphql/pubspec.yaml
@@ -2,16 +2,12 @@ name: graphql
 description:
   A stand-alone GraphQL client for Dart, bringing all the features from
   a modern GraphQL client to one easy to use package.
-version: 3.1.0-beta.4
-authors:
-  - Eus Dima <[email protected]>
-  - Zino Hofmann <[email protected]>
-  - Michael Joseph Rosenthal <[email protected]>
-  - TruongSinh Tran-Nguyen <[email protected]>
+version: 4.0.0-alpha.0
 homepage: https://github.com/zino-app/graphql-flutter/tree/master/packages/graphql
 dependencies:
   meta: ^1.1.6
   path: ^1.6.2
+
   gql: ^0.12.0
   gql_exec: ^0.2.2
   gql_link: ^0.3.0
@@ -22,15 +18,17 @@ dependencies:
   gql_dedupe_link: ^1.0.10
 
   hive: ^1.3.0
-
-  quiver: ">=2.0.0 <3.0.0"
   normalize: ^0.2.0
+  http: ^0.12.1
+  collection: ^1.14.12
+
 
 dev_dependencies:
   pedantic: ^1.8.0+1
   mockito: ^4.0.0
   test: ^1.5.3
   test_coverage: ^0.3.0+1
+
 environment:
   sdk: ">=2.6.0 <3.0.0"
 
diff --git a/packages/graphql/test/anonymous_operations_test.dart b/packages/graphql/test/anonymous_operations_test.dart
@@ -158,7 +158,7 @@ void main() {
               operation: Operation(
                 document: parseString(addStar),
               ),
-              variables: <String, dynamic>{},
+              variables: {},
               context: Context(),
             ),
           ),

diff --git a/packages/graphql/test/graphql_client_test.dart b/packages/graphql/test/graphql_client_test.dart
@@ -102,7 +102,7 @@ void main() {
             Request(
               operation: Operation(
                 document: parseString(readRepositories),
-                operationName: 'ReadRepositories',
+                //operationName: 'ReadRepositories',
               ),
               variables: <String, dynamic>{
                 'nRepositories': 42,
@@ -208,7 +208,7 @@ void main() {
             Request(
               operation: Operation(
                 document: parseString(addStar),
-                operationName: 'AddStar',
+                //operationName: 'AddStar',
               ),
               variables: <String, dynamic>{},
               context: Context(),