Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zigpy-zigate 0.8.0 or newer 0.8.x release with later fixes already added? #93

Open
Hedda opened this issue Jun 8, 2021 · 9 comments
Open

Comments

@Hedda
Copy link
Contributor

Hedda commented Jun 8, 2021

@doudz Looks like you bumped zigpy-zigate version to 0.8.0 but missed tagging it for release so not available via PyPI/pip?

ZeGuigui wrote this here:

69b02f1

Do you plan to add a tag so this release will be pushed to pypi.org or should I hard install it to test the reconnect feature?

https://github.com/zigpy/zigpy-zigate/releases

https://github.com/zigpy/zigpy-zigate/tags

https://pypi.org/project/zigpy-zigate/#history

https://pypi.org/project/zigpy-zigate/#files

If and when it is ready I assume will also update Home Assistant core via a PR?

https://github.com/home-assistant/core/pulls?q=zigpy-zigate

@Hedda
Copy link
Contributor Author

Hedda commented Jun 8, 2021

@doudz
Copy link
Collaborator

doudz commented Jun 9, 2021

the release is not ready that's why I didn't tag it

@Hedda
Copy link
Contributor Author

Hedda commented Jun 10, 2021

the release is not ready that's why I didn't tag it

OK. Just assumed based on 69b02f1 bump as usually major and minor version bumps are done last just before release

@Hedda
Copy link
Contributor Author

Hedda commented Nov 16, 2021

@doudz Any chance you could test and bump the release version 0.8.1

Home Assistant core looks to still be using zigpy-zigate 0.7.3 release:

https://github.com/home-assistant/core/blob/dev/homeassistant/components/zha/manifest.json

https://github.com/home-assistant/core/pulls?q=zigpy-zigate

That does not contain the later fixes that you added after that.

See comment by @Xavier-M in #101 so maybe he is willing to test it.

@Hedda Hedda changed the title zigpy-zigate 0.8.0 or 0.8.x release tag missing? zigpy-zigate 0.8.0 or newer 0.8.x release with later fixes already added? Nov 16, 2021
@doudz
Copy link
Collaborator

doudz commented Nov 17, 2021

Sorry, no time to work on zigate 😞

@MichaelBitard
Copy link
Contributor

Hi @doudz, do you think you could release the 0.8.0? We could take care of the testing in home assistant, and do the PR to integrate it in ZHA if needed.

@Hedda
Copy link
Contributor Author

Hedda commented Jan 25, 2022

@MichaelBitard Check out the somewhat related discussion in #104 about help with test mentioned fork with Home Assistant.

Help if needed regression testing mentioned zigpy-zigate fork as if it does not break anything PRs can be submitted upstream.

That is, those working on that fork can/will not test ZHA themselves but they can submit PRs here if someone else can test it.

@Gemies
Copy link

Gemies commented Feb 4, 2022

That would be very much appreciated when 0.8.0 is released so at least.whe can test it. I am not relying on the Zigate wifi. So testing would be nice.

@Hedda
Copy link
Contributor Author

Hedda commented Feb 6, 2022

FYI, please read discussions in #116 and zigpy/zigpy#880 about zigpy-zigate first needing additional maintainer(s) to volunteer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants