Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting Manufacturer ID #187

Open
Tracked by #1235
pipiche38 opened this issue Mar 14, 2022 · 11 comments
Open
Tracked by #1235

Setting Manufacturer ID #187

pipiche38 opened this issue Mar 14, 2022 · 11 comments

Comments

@pipiche38
Copy link

I understood that deConz has a particular mecanism to set the Manufactuer ID to address the Aqara/Lumi needs.
Is there a specific API in zigpy to do that ?

@pipiche38 pipiche38 changed the title Seting Manufacturer ID Setting Manufacturer ID Mar 14, 2022
@puddly
Copy link
Contributor

puddly commented Mar 15, 2022

According to the firmware changelog, it may be automatic: https://github.com/dresden-elektronik/deconz-rest-plugin/wiki/Firmware-Changelog

If not, there seems to be a way to allow Node Descriptor requests to be passed through to the application, allowing it to be set in there:

image

@pipiche38
Copy link
Author

My understanding is that is a set of Attribute to be set like extendedPanId and other network parameters. So I beleiuve we need a deconz api to set this attribute, no ?

@puddly
Copy link
Contributor

puddly commented Mar 15, 2022

I do not have any of the new Aqara devices to test.

If this is done automatically in the firmware like Z-Stack and I believe you mentioned ZiGate, no code changes are needed. If the firmware doesn't handle it, zigpy-deconz will need to be updated.

@pipiche38
Copy link
Author

I can for sure test it as I have one Aqara door device. My understanding is that we have to do it for deconz as by default it is 0x0000.

The best would be to have a simple api to set the manufactuer Id, so we can call it on the fly when receiving a device annoucement of an Aqara devices. And then or reset back to 0x0000 when not

@pipiche38
Copy link
Author

What is the zigpy API in order to set and get the information ?

@Adminiuga
Copy link
Collaborator

I didn't have the need to set manufacturer Id for ConBee. Aqara stayed connected just fine. But you do need the new firmware

@pipiche38
Copy link
Author

I didn't have the need to set manufacturer Id for ConBee. Aqara stayed connected just fine. But you do need the new firmware

It just depends on the Aqara model. if you have the old one, no issue at all. Here the issue is even if it get connectedf, it doesn't work (doesn't provide the correct reports).

A patch as been done for CCxxx firmware to reply with the right manufacturer Id , while on deconz a more open soltuion as been provided on the firmware and delegate the answer to the above layer.

My question is then is there any API yet to set the manufacturer Id

@Adminiuga
Copy link
Collaborator

Yeah, that was tested with the new Aqara.
There's no API for that, because it is very radio specific.

@pipiche38
Copy link
Author

Why should we not have an API. if it is radio specific, at least this must be part of zigpy-deconz API, otherwise I don't see how to set/update it

@puddly
Copy link
Contributor

puddly commented May 9, 2022

Why should we not have an API

Because zigpy doesn't currently have a need for one and thus nobody has written one for all the radios yet.

I believe bellows is the only other radio library that supports setting the manufacturer ID. The deCONZ firmware requires you to reply to node descriptor requests.

Feel free to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants