Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsupported linker arg: --enable-new-dtags #18249

Closed
scalpel4k opened this issue Dec 10, 2023 · 2 comments
Closed

unsupported linker arg: --enable-new-dtags #18249

scalpel4k opened this issue Dec 10, 2023 · 2 comments
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. linking zig cc Zig as a drop-in C compiler feature
Milestone
0.12.0

Comments

@scalpel4k
Copy link

Zig Version

0.12.0-dev.1807+d27002011

Steps to Reproduce and Observed Behavior

Since version 1.74 rustc now adds -Wl,--enable-new-dtags when it thinks ld is used for linking c libraries.

this has been added with this MR: rust-lang/rust#30394

I tried this doing cargo install cargo-workspaces for instance.

Expected Behavior

....
@scalpel4k scalpel4k added the bug Observed behavior contradicts documented or intended behavior label Dec 10, 2023
@dmeijboom dmeijboom mentioned this issue Feb 22, 2024
Closed
@andrewrk andrewrk added linking and removed bug Observed behavior contradicts documented or intended behavior labels Feb 24, 2024
@andrewrk andrewrk added this to the 0.13.0 milestone Feb 24, 2024
@andrewrk andrewrk added the zig cc Zig as a drop-in C compiler feature label Feb 24, 2024
@andrewrk
Copy link
Member

What an unfortunate name the ld project has chosen for that flag. Wouldn't it be great if they could name the flag after what it actually does.

@andrewrk andrewrk added the enhancement Solving this issue will likely involve adding new logic or components to the codebase. label Feb 24, 2024
@andrewrk andrewrk modified the milestones: 0.13.0, 0.12.0 Feb 24, 2024
@andrewrk
Copy link
Member

Landed in 377ecc6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Solving this issue will likely involve adding new logic or components to the codebase. linking zig cc Zig as a drop-in C compiler feature
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

feat: add support for --enable-new-dtags and --disable-new-dtags brainhivenl/zig
2 participants
@andrewrk @scalpel4k