Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass EVENTS.DOM to onEvent #185

Merged
merged 2 commits into from
Aug 10, 2021
Merged

fix: pass EVENTS.DOM to onEvent #185

merged 2 commits into from
Aug 10, 2021

Conversation

ambar
Copy link
Collaborator

@ambar ambar commented Aug 10, 2021

aftdotleo
aftdotleo approved these changes Aug 10, 2021
View reviewed changes
Copy link
Collaborator

@aftdotleo aftdotleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ambar ambar merged commit 8f10e6b into zhihu:master Aug 10, 2021
@ambar ambar deleted the event branch September 15, 2021 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aftdotleo aftdotleo aftdotleo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ambar @aftdotleo