Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose onFullScreenChange event #174

Merged
merged 1 commit into from
May 25, 2021

Conversation

xia5517
Copy link
Contributor

@xia5517 xia5517 commented May 25, 2021

Pull Request Template

Description

expose onFullScreenChange event to outside.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • 自测

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2021

Codecov Report

Merging #174 (383093e) into master (1bf8917) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   48.77%   48.67%   -0.11%     
==========================================
  Files         128      128              
  Lines        1843     1847       +4     
==========================================
  Hits          899      899              
- Misses        944      948       +4     
Impacted Files Coverage Δ
packages/griffith/src/components/Player/Player.js 0.00% <0.00%> (ø)
.../src/components/PlayerContainer/PlayerContainer.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bf8917...383093e. Read the comment docs.

@ambar ambar merged commit 2d8d444 into zhihu:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants