Skip to content

Commit

Permalink
Illumos #3517
Browse files Browse the repository at this point in the history
3517 importing pool with autoreplace=on and "hole" vdevs crashes syseventd
Reviewed by: Albert Lee <[email protected]>
Reviewed by: Jeffry Molanus <[email protected]>
Reviewed by: George Wilson <[email protected]>
Approved by: Christopher Siden <[email protected]>

References:
  https://www.illumos.org/issues/3517
  illumos/illumos-gate@efb4a87

Ported-by: Richard Yao <[email protected]>
Signed-off-by: Brian Behlendorf <[email protected]>
Issue #1775
  • Loading branch information
Yuri Pankov authored and behlendorf committed Oct 31, 2013
1 parent d1fada1 commit 7011fb6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions module/zfs/spa.c
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@

/*
* Copyright (c) 2005, 2010, Oracle and/or its affiliates. All rights reserved.
* Copyright 2011 Nexenta Systems, Inc. All rights reserved.
* Copyright (c) 2012 by Delphix. All rights reserved.
* Copyright 2013 Nexenta Systems, Inc. All rights reserved.
*/

/*
Expand Down Expand Up @@ -1597,7 +1597,8 @@ spa_check_removed(vdev_t *vd)
for (c = 0; c < vd->vdev_children; c++)
spa_check_removed(vd->vdev_child[c]);

if (vd->vdev_ops->vdev_op_leaf && vdev_is_dead(vd)) {
if (vd->vdev_ops->vdev_op_leaf && vdev_is_dead(vd) &&
!vd->vdev_ishole) {
zfs_ereport_post(FM_EREPORT_RESOURCE_AUTOREPLACE,
vd->vdev_spa, vd, NULL, 0, 0);
spa_event_notify(vd->vdev_spa, vd, FM_EREPORT_ZFS_DEVICE_CHECK);
Expand Down

0 comments on commit 7011fb6

Please sign in to comment.