systemd and LSB scripts run parallel #172

ggzengel · 2015-09-23T13:53:34Z

# uname -a
Linux xenserver1 4.1.0-0.bpo.2-amd64 #1 SMP Debian 4.1.6-1~bpo8+1 (2015-09-09) x86_64 GNU/Linux

# cat /etc/apt/sources.list.d/zfsonlinux.list 
deb http://archive.zfsonlinux.org/debian jessie main

On boot I see ZFS pool import twice. One LSB and one Systemd. They run both on same time.

With systemd there is a lot to do. It always import pool by ID:

cat zfs-import-scan.service | grep ExecStart=

ExecStart=/sbin/zpool import -d /dev/disk/by-id -aN

I think this won't work with the code above:
ZPOOL_IMPORT_PATH="/dev/disk/by-vdev:/dev/disk/by-id"

Perhaps these are changes from Turbo?
The idea behind this is OK, because I like to import pools by partlabel.

The text was updated successfully, but these errors were encountered:

ggzengel · 2015-09-23T15:49:18Z

You should make two packages. One for SYSV and one for systemd.

FransUrbo · 2015-09-23T15:59:34Z

Shouldn't be needed and from what I can tell, no one else is doing that.

There is a recommended, safe way to mix systemd and sysv scripts. This uses the Debian GNU/Linux tools to maintain the two different ways.

Once you enable systemd, the sysv init scripts is disabled. OR, if there is no systemd scripts, the sysv init scripts is converted into systemd config files...

ggzengel · 2015-09-23T16:19:07Z

> systemctl cat zfs-import.service 
# /run/systemd/generator.late/zfs-import.service
# Automatically generated by systemd-sysv-generator

[Unit]
SourcePath=/etc/init.d/zfs-import
Description=LSB: Import ZFS pools
DefaultDependencies=no
Before=checkfs.service sysinit.target shutdown.target
After=mtab.service
Conflicts=shutdown.target

[Service]
Type=forking
Restart=no
TimeoutSec=0
IgnoreSIGPIPE=no
KillMode=process
GuessMainPID=no
RemainAfterExit=yes
SysVStartPriority=8
ExecStart=/etc/init.d/zfs-import start
ExecStop=/etc/init.d/zfs-import stop

# systemctl list-unit-files | grep zfs
zfs-import-cache.service               static  
zfs-import-scan.service                static  
zfs-mount.service                      static  
zfs-share.service                      static  
xen_zfs.target                         enabled 
zfs.target                             enabled

I wrote xen_zfs.target:

> systemctl cat xen_zfs.target 
# /etc/systemd/system/xen_zfs.target
[Unit]
Description=Xen needs ZFS/NFS
Requires=zfs-share.service
After=zfs-share.service
Before=xendomains.service

[Install]
RequiredBy=xendomains.service

ggzengel · 2015-09-23T16:22:02Z

I forgot this:

> systemctl list-units | grep zfs
zfs-import-cache.service                                                                         loaded active exited    Import ZFS pools by cache file
zfs-import.service                                                                               loaded active exited    LSB: Import ZFS pools
zfs-mount.service                                                                                loaded active exited    Mount ZFS filesystems
zfs-share.service                                                                                loaded active exited    ZFS file system shares
zfs-zed.service                                                                                  loaded active exited    LSB: ZFS Event Daemon
xen_zfs.target                                                                                   loaded active active    Xen needs ZFS/NFS
zfs.target                                                                                       loaded active active    ZFS startup target

FransUrbo · 2015-09-23T16:25:10Z

The package come with both sysv and systemd scripts included. Don't know why you have a auto-generated script there!

Did you install the packages on a system that didn't use systemd, then changed to systemd and that when the problem started perhaps?

ggzengel · 2015-09-23T16:30:36Z

This system was debootstraped from wheezy but with dist jessie early with zfs 2.6.3.
On 2.6.4 I have seen that one package was version wheezy and I changed to jessie later. While changing from wheezy to jessie I was asked something about downgrade.

ggzengel · 2015-09-23T16:32:12Z

After bootstraping I booted jessie and after that I added zfs,

FransUrbo · 2015-09-23T16:35:28Z

Debootstrap don't install systemd for you as far as I know. So somewhere in all that, systemd must have gone active, so my idea sounds plausible.

But that still don't explain why you're running with generated systemd files...

ggzengel · 2015-09-23T16:37:41Z

How to get rid of this?
Remove and install again?

FransUrbo · 2015-09-23T16:40:14Z

I have absolutly no idea!

You could always try using dpkg --purge ….

OR, just move the sysv scripts out the way. Move them to your home directory or something. You can always move them back if it turns out to be a problem.

ggzengel · 2015-09-23T17:09:44Z

What's about this? Both should have the same name.

# systemctl list-units | grep zed
zed.service                                                                                      loaded active running   ZFS Event Daemon (zed)
zfs-zed.service                                                                                  loaded active exited    LSB: ZFS Event Daemon

Without LSB ZED it didn't need LSB mount.

ggzengel · 2015-09-23T17:17:23Z

I think there should be something about zfs-import.target to have the same name as /etc/init.d/zfs-import.

ggzengel · 2015-09-23T17:38:44Z

Why do you not unshare, unmount or export like init.d?

FransUrbo · 2015-09-23T18:20:45Z

zed.service loaded active running ZFS Event Daemon (zed)

Actually, that is very likely a leftover from an earlier package and shouldn't be there.

I think there should be something about zfs-import.target to have the same name as /etc/init.d/zfs-import.

Yes. And zfs-share and zfs-mount as well!

ggzengel · 2015-09-23T19:46:26Z

Sure?

> dpkg -S zfs-zed
zfsutils: /etc/init.d/zfs-zed

 > dpkg -S zed.service
zfsutils: /lib/systemd/system/zed.service

Both have time stamp: Sep 20 10:55

FransUrbo · 2015-09-23T21:12:36Z

You're right! We must have missed to rename that when the new SYSV init scripts was accepted!

I've opened a different issue about that...

But that was just a side note. It still doesn't explain the original problem you're having.

FransUrbo · 2015-09-23T21:15:14Z

@dajhorn You've worked with systemd quite a lot, do you have any clue or idea on what could be the problem?

ggzengel · 2015-09-23T21:47:43Z

That's exactly the problem. You have 3 active import scripts:

zfs-import-cache.service
zfs-import-scan.service
/etc/init.d/zfs-import

and two off them running at boot time.

ggzengel · 2015-09-23T21:50:21Z

Perhaps you rename zfs-import-cache.service to zfs-import.service with all dependencies and the problem is gone.

FransUrbo · 2015-09-23T21:59:52Z

The two service files do two different things. Or rather, import the pool(s) in different way, so they must both remain. So that isn't the solution either.

ggzengel · 2015-09-23T22:03:40Z

Than you have to make a dummy zfs-import.service.

FransUrbo · 2015-09-23T22:10:11Z

No! You need to take a step back and breath!

We do NOT go around writing code or anything else to fix a possible problem that so far have affected only ONE person out of hundreds, maybe thousands! AND we have not ruled out user error yet!

ggzengel · 2015-09-23T22:29:27Z

I don't have only one system.
On the other one with plain jessie installed i have the same:

root@zfs1:~# systemctl list-units | grep zfs
  zfs-import-cache.service                                                                         loaded active exited    Import ZFS pools by cache file
  zfs-import.service                                                                               loaded active exited    LSB: Import ZFS pools
  zfs-mount.service                                                                                loaded active exited    Mount ZFS filesystems
  zfs-share.service                                                                                loaded active exited    ZFS file system shares
● zfs-zed.service                                                                                  loaded failed failed    LSB: ZFS Event Daemon
  zfs.target                                                                                       loaded active active    ZFS startup target

ggzengel · 2015-09-23T23:32:17Z

Here is an other system before and after update. Now look and see:

root@xenserver2:~# uname -a
Linux xenserver2 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1+deb8u3 (2015-08-04) x86_64 GNU/Linux

root@xenserver2:~# modinfo zfs 
filename:       /lib/modules/3.16.0-4-amd64/updates/dkms/zfs.ko
version:        0.6.4-1.2-1

# dpkg-query -l zfsutils
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                                Version                Architecture           Description
+++-===================================-======================-======================-============================================================================
ii  zfsutils                            0.6.4-1.2-1            amd64                  command-line tools to manage ZFS filesystems

root@xenserver2:~# ls -la /etc/init.d/z*
-rwxr-xr-x 1 root root 3908 May 28 14:25 /etc/init.d/zed
-rwxr-xr-x 1 root root 5870 May 28 14:25 /etc/init.d/zfs-mount
-rwxr-xr-x 1 root root 2310 May 28 14:25 /etc/init.d/zfs-share

root@xenserver2:~# ls -la /lib/systemd/system/z*
-rw-r--r-- 1 root root 179 Jun 27 13:29 /lib/systemd/system/zed.service
-rw-r--r-- 1 root root 342 Jun 27 13:29 /lib/systemd/system/zfs-import-cache.service
-rw-r--r-- 1 root root 343 Jun 27 13:29 /lib/systemd/system/zfs-import-scan.service
-rw-r--r-- 1 root root 353 Jun 27 13:29 /lib/systemd/system/zfs-mount.service
-rw-r--r-- 1 root root 294 Jun 27 13:29 /lib/systemd/system/zfs-share.service
-rw-r--r-- 1 root root 148 Jun 27 13:29 /lib/systemd/system/zfs.target

root@xenserver2:~# systemctl list-units | grep -e ^z
zed.service                                                                                                   loaded active running   ZFS Event Daemon (zed)
zfs-import-cache.service                                                                                      loaded active exited    Import ZFS pools by cache file
zfs-mount.service                                                                                             loaded active exited    Mount ZFS filesystems
zfs-share.service                                                                                             loaded active exited    ZFS file system shares
zfs.target                                                                                                    loaded active active    ZFS startup target

root@xenserver2:~# systemctl list-unit-files | grep -e ^z
zed.service                            static  
zfs-import-cache.service               static  
zfs-import-scan.service                static  
zfs-mount.service                      static  
zfs-share.service                      static  
zfs.target                             enabled

root@xenserver2:~# uname -a
Linux xenserver2 3.16.0-4-amd64 #1 SMP Debian 3.16.7-ckt11-1+deb8u4 (2015-09-19) x86_64 GNU/Linux

root@xenserver2:~# modinfo zfs 
filename:       /lib/modules/3.16.0-4-amd64/updates/dkms/zfs.ko
version:        0.6.5.1-4

root@xenserver2:~# dpkg-query -l zfsutils
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name                                Version                Architecture           Description
+++-===================================-======================-======================-============================================================================
ii  zfsutils                            0.6.5.1-4              amd64                  command-line tools to manage ZFS filesystems

root@xenserver2:~# ls -la /etc/init.d/z*
-rwxr-xr-x 1 root root 5549 Sep 23 14:45 /etc/init.d/zfs-import
-rwxr-xr-x 1 root root 5362 Sep 23 14:45 /etc/init.d/zfs-mount
-rwxr-xr-x 1 root root 2252 Sep 23 14:45 /etc/init.d/zfs-share
-rwxr-xr-x 1 root root 2802 Sep 23 14:45 /etc/init.d/zfs-zed


root@xenserver2:~# ls -la /lib/systemd/system/z*
-rw-r--r-- 1 root root 179 Sep 23 14:45 /lib/systemd/system/zed.service
-rw-r--r-- 1 root root 342 Sep 23 14:45 /lib/systemd/system/zfs-import-cache.service
-rw-r--r-- 1 root root 343 Sep 23 14:45 /lib/systemd/system/zfs-import-scan.service
-rw-r--r-- 1 root root 353 Sep 23 14:45 /lib/systemd/system/zfs-mount.service
-rw-r--r-- 1 root root 294 Sep 23 14:45 /lib/systemd/system/zfs-share.service
-rw-r--r-- 1 root root 148 Sep 23 14:45 /lib/systemd/system/zfs.target

root@xenserver2:~# systemctl list-units | grep -e ^..z
  zed.service                                                                                      loaded active running   ZFS Event Daemon (zed)
  zfs-import-cache.service                                                                         loaded active exited    Import ZFS pools by cache file
  zfs-import.service                                                                               loaded active exited    LSB: Import ZFS pools
  zfs-mount.service                                                                                loaded active exited    Mount ZFS filesystems
  zfs-share.service                                                                                loaded active exited    ZFS file system shares
● zfs-zed.service                                                                                  loaded failed failed    LSB: ZFS Event Daemon
  zfs.target                                                                                       loaded active active    ZFS startup target

FransUrbo · 2015-09-24T07:35:20Z

My point is that this more and more seems like an upstream problem. SYSV init scripts and systemd should not run at the same time.

Could you take this to either the Debian GNU/Linux bug tracker or, preferable, to their mailing lists.

Granted, ZFS isn't supported by them (yet), but it seems to be a problem with their tools or something.

ggzengel · 2015-09-24T14:32:24Z

No, you are absolutely wrong.,
If you add /etc/init.d/zfs-import and don't add zfs-import.service it will use /etc/init.d.

FransUrbo · 2015-09-24T16:28:48Z

You're completely missing my point and isn't listening to what I'm saying.

I can't reproduce this (and no one else seems to have ever seen this problem) so I'm going to close this as an upstream (Debian GNU/Linux) issue - OR user error.

If you come back with references from their bug tracker and/or mailing list that's stating that it's something I have done, we can reopen it.

ggzengel · 2015-09-24T19:25:51Z

I bet everybody with plain jessie with systemd will have this issue.

ggzengel · 2015-09-24T19:35:33Z

http://0pointer.de/public/systemd-man/systemd-sysv-generator.html

FransUrbo mentioned this issue Sep 23, 2015

Rename 'zed.service' to 'zfs-zed.service' openzfs/zfs#3824

Closed

FransUrbo closed this as completed Sep 24, 2015

FransUrbo mentioned this issue Sep 25, 2015

prevent running /etc/init.d/zfs-import if using systemd openzfs/zfs#3838

Closed

ggzengel mentioned this issue Sep 26, 2015

prevent /etc/init.d/zfs-import from running with systemd openzfs/zfs#3839

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

systemd and LSB scripts run parallel #172

systemd and LSB scripts run parallel #172

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 24, 2015

ggzengel commented Sep 24, 2015

FransUrbo commented Sep 24, 2015

ggzengel commented Sep 24, 2015

ggzengel commented Sep 24, 2015

systemd and LSB scripts run parallel #172

systemd and LSB scripts run parallel #172

Comments

ggzengel commented Sep 23, 2015

cat zfs-import-scan.service | grep ExecStart=

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 23, 2015

ggzengel commented Sep 23, 2015

ggzengel commented Sep 23, 2015

FransUrbo commented Sep 24, 2015

ggzengel commented Sep 24, 2015

FransUrbo commented Sep 24, 2015

ggzengel commented Sep 24, 2015

ggzengel commented Sep 24, 2015