Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include zimbraAllowFromAddress in sender address list #542

Merged
merged 19 commits into from
Nov 13, 2024
Merged

fix: include zimbraAllowFromAddress in sender address list #542

merged 19 commits into from
Nov 13, 2024

Conversation

aheeva-yuliya
Copy link
Member

@aheeva-yuliya aheeva-yuliya commented Nov 8, 2024 •
edited
Loading

This PR implements the functionality to retrieve values from the zimbraAllowFromAddress setting and add them to the existing address list that a user can use as their "sender" address.

Refs: CO-1364

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
1 similar comment
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@aheeva-yuliya aheeva-yuliya marked this pull request as ready for review November 12, 2024 10:24
@aheeva-yuliya aheeva-yuliya requested review from a team as code owners November 12, 2024 10:24
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@aheeva-yuliya aheeva-yuliya changed the title chore: use zimbraAllowFromAddress fix: include zimbraAllowFromAddress in sender address list Nov 12, 2024
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
beawar
beawar reviewed Nov 12, 2024
View reviewed changes
src/settings/components/utils.ts Outdated Show resolved Hide resolved
src/settings/components/utils.ts Outdated Show resolved Hide resolved
src/settings/components/utils.ts Outdated Show resolved Hide resolved
src/settings/components/utils.ts Outdated Show resolved Hide resolved
src/settings/components/utils.ts Outdated Show resolved Hide resolved
src/settings/components/utils.test.ts Outdated Show resolved Hide resolved
src/settings/components/utils.ts Outdated Show resolved Hide resolved
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
beawar
beawar reviewed Nov 12, 2024
View reviewed changes
src/settings/components/utils.ts Outdated Show resolved Hide resolved
src/types/account/index.ts Show resolved Hide resolved
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
beawar
beawar reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests can be cleaned up a bit more, everything else looks good to me now

src/settings/components/utils.test.ts Outdated Show resolved Hide resolved
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (66.50% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

beawar
beawar approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beawar beawar merged commit 4cc9e27 into devel Nov 13, 2024
3 checks passed
@beawar beawar deleted the handle-zimbraAllowFromAddress branch November 13, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zextrasGiovanniDefacci zextrasGiovanniDefacci zextrasGiovanniDefacci approved these changes

@CataldoMazzilli CataldoMazzilli CataldoMazzilli approved these changes

@beawar beawar beawar approved these changes

@dhavaldodiya dhavaldodiya Awaiting requested review from dhavaldodiya

@mananpatel13589 mananpatel13589 Awaiting requested review from mananpatel13589

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aheeva-yuliya @CLAassistant @beawar @CataldoMazzilli @zextrasGiovanniDefacci