Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: noOp endless loop #486

Merged
merged 5 commits into from
Aug 21, 2024
Merged

fix: noOp endless loop #486

merged 5 commits into from
Aug 21, 2024

Conversation

mgarbin
Copy link
Contributor

@mgarbin mgarbin commented Aug 19, 2024 •
edited
Loading

Refs: SHELL-239

@mgarbin mgarbin requested review from a team as code owners August 19, 2024 14:50
@CLAassistant
Copy link

CLAassistant commented Aug 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
beawar
beawar reviewed Aug 19, 2024
View reviewed changes
src/store/network/utils.ts Outdated Show resolved Hide resolved
@mgarbin @beawar
Update src/store/network/utils.ts
0401774 
Co-authored-by: Beatrice Guerra <[email protected]>
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
beawar
beawar reviewed Aug 21, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is still failing

@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (65.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@CataldoMazzilli
Copy link
Member

I approve but this part needs a deeper refactor

@beawar beawar merged commit 6b571d8 into devel Aug 21, 2024
3 checks passed
@beawar beawar deleted the fix_NoOp-loop branch August 21, 2024 12:43
@beawar
Copy link
Contributor

beawar commented Aug 21, 2024

I approve but this part needs a deeper refactor

I agree, by just implementing a couple of tests multiple problems on the parsing are emerged.
We need to review the polling entirely (consider also that it is related to a mail pref, set by mails, I honestly think this should not be shell code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CataldoMazzilli CataldoMazzilli CataldoMazzilli approved these changes

@beawar beawar beawar approved these changes

@gnekoz gnekoz Awaiting requested review from gnekoz

@nubsthead nubsthead Awaiting requested review from nubsthead

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgarbin @CLAassistant @CataldoMazzilli @beawar