Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: translate unit measures for size #485

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: translate unit measures for size #485

merged 1 commit into from
Aug 20, 2024

Conversation

beawar
Copy link
Contributor

@beawar beawar commented Aug 19, 2024 •
edited
Loading

Refs: SHELL-236

Add translations:

  • "size.unitMeasure_B": "B"
  • "size.unitMeasure_KB": "KB"
  • "size.unitMeasure_MB": "MB"
  • "size.unitMeasure_GB": "GB"
  • "size.unitMeasure_TB": "TB"
  • "size.unitMeasure_PB": "PB"
  • "size.unitMeasure_EB": "EB"
  • "size.unitMeasure_ZB": "ZB"
  • "size.unitMeasure_YB": "YB"

@beawar beawar self-assigned this Aug 19, 2024
@beawar beawar requested review from a team as code owners August 19, 2024 07:46
@sonarqube-zextras Sonarqube Zextras

This comment has been minimized.

Sign in to view
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (65.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@beawar beawar merged commit 375ff7f into devel Aug 20, 2024
4 checks passed
@beawar beawar deleted the SHELL-236-translate-size-unit-measure branch August 20, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodleyorosa rodleyorosa rodleyorosa approved these changes

@CataldoMazzilli CataldoMazzilli CataldoMazzilli approved these changes

Assignees

@beawar beawar

Labels
validated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beawar @CataldoMazzilli @rodleyorosa @eugeniamuff