Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell 219 enhance primary bar component to include common customizations #483

Conversation

CataldoMazzilli
Copy link
Member

No description provided.

@CataldoMazzilli CataldoMazzilli requested review from a team as code owners August 14, 2024 10:25
…imary-bar-component-to-include-common-customizations

This comment has been minimized.

This comment has been minimized.

@CataldoMazzilli CataldoMazzilli self-assigned this Aug 19, 2024
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing point to do: the PrimaryBarElement should pass down all the props to the custom component, instead of only the active prop

@CataldoMazzilli CataldoMazzilli requested a review from beawar August 20, 2024 07:40

This comment has been minimized.

…imary-bar-component-to-include-common-customizations
@CataldoMazzilli CataldoMazzilli requested review from eugeniamuff and removed request for eugeniamuff August 20, 2024 08:39
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (64.90% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@CataldoMazzilli CataldoMazzilli merged commit 9533065 into devel Aug 20, 2024
2 checks passed
@CataldoMazzilli CataldoMazzilli deleted the SHELL-219-Enhance-primary-bar-component-to-include-common-customizations branch August 20, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants