-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell 219 enhance primary bar component to include common customizations #483
Merged
CataldoMazzilli
merged 8 commits into
devel
from
SHELL-219-Enhance-primary-bar-component-to-include-common-customizations
Aug 20, 2024
Merged
Shell 219 enhance primary bar component to include common customizations #483
CataldoMazzilli
merged 8 commits into
devel
from
SHELL-219-Enhance-primary-bar-component-to-include-common-customizations
Aug 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imary-bar-component-to-include-common-customizations
This comment has been minimized.
This comment has been minimized.
beawar
reviewed
Aug 14, 2024
This comment has been minimized.
This comment has been minimized.
beawar
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a missing point to do: the PrimaryBarElement should pass down all the props to the custom component, instead of only the active prop
This comment has been minimized.
This comment has been minimized.
…imary-bar-component-to-include-common-customizations
CataldoMazzilli
requested review from
eugeniamuff
and removed request for
eugeniamuff
August 20, 2024 08:39
Analysis Details0 IssuesCoverage and DuplicationsProject ID: carbonio-shell-ui |
beawar
approved these changes
Aug 20, 2024
rodleyorosa
approved these changes
Aug 20, 2024
CataldoMazzilli
deleted the
SHELL-219-Enhance-primary-bar-component-to-include-common-customizations
branch
August 20, 2024 09:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.