Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose a function to update settings store #451

Merged
merged 42 commits into from
Jul 1, 2024
Merged

feat: expose a function to update settings store #451

merged 42 commits into from
Jul 1, 2024

Conversation

gnekoz
Copy link
Contributor

@gnekoz gnekoz commented Jun 24, 2024

  • Create and export updateSettings and updateAccount functions
  • Refactor functions for merge props and prefs

Refs: SHELL-226

nubsthead and others added 23 commits June 20, 2024 15:46
@nubsthead
feat: expose useAccountStore settings setter
aed1c33
@nubsthead
chore: update api extractor md file
4292cf6
@matteobaglini
feat: add updateIdentities function
a2600f0
@matteobaglini
feat: add UpdateAccount function
a51bf8b
@matteobaglini
feat: add updateAccount to useAccount hook
894c36d
@matteobaglini
feat: implement UpdateAccount function
43a94af
@matteobaglini
chore: update carbonio-shell-ui.api.md
a37f1a6
@gnekoz
type(useUserAccount): update return type
5550f5a
@gnekoz
chore: update api-extractor md
60e7e94
@gnekoz
refactor: move updateSettings and updateAccount in specific hooks
13b651d
@gnekoz
refactor: change export functions of updaters for user account and se…
100ca4a 
…ttings
@nubsthead
refactor: remove duplicated code to update settings
0e7d573
@nubsthead
refactor(settings): improve updateAccount response parameter type
75814cd
@gnekoz
refactor: extend setupAccountStore to accept additional settings
134c294
@nubsthead
test(settings): test implementation of settings utils
d66b6e1
@gnekoz
refactor: update tests to align with the setupAccountStore new signature
83dd9c2
@gnekoz
Merge branch 'SHELL-226-Expose-a-function-to-update-settings-store' o…
58ec6f2 
…f github.com:zextras/carbonio-shell-ui into SHELL-226-Expose-a-function-to-update-settings-store
@gnekoz
test: add partial tests for updateSettings
5ce00e6
@gnekoz
chore: remove useless tests
1c86d45
@gnekoz
style: add blank line between tests
d5d41b9
@gnekoz
test: add tests for the mergeAttrs function
195457d
@gnekoz
test: add tests for merge existing setting value
5452f62
@gnekoz
refactor: fix mergeProps to return immutable result
30639d5
@gnekoz gnekoz requested review from a team as code owners June 24, 2024 13:00
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 41.30% Coverage on New Code (is less than 80.00%)
  • 1 New Issues (is greater than 0)

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 41.30% Coverage (63.00% Estimated after merge)
  • Duplications 0.91% Duplicated Code (6.30% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

1 similar comment
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 41.30% Coverage on New Code (is less than 80.00%)
  • 1 New Issues (is greater than 0)

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 41.30% Coverage (63.00% Estimated after merge)
  • Duplications 0.91% Duplicated Code (6.30% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

beawar
beawar reviewed Jun 26, 2024
View reviewed changes
src/types/account/index.ts Outdated Show resolved Hide resolved
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 36.50% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 36.50% Coverage (63.00% Estimated after merge)
  • Duplications 0.90% Duplicated Code (6.30% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 37.30% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 37.30% Coverage (62.70% Estimated after merge)
  • Duplications 0.91% Duplicated Code (6.30% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 37.30% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 37.30% Coverage (62.70% Estimated after merge)
  • Duplications 0.90% Duplicated Code (6.30% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 37.30% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 37.30% Coverage (62.60% Estimated after merge)
  • Duplications 0.91% Duplicated Code (6.30% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

beawar
beawar reviewed Jun 27, 2024
View reviewed changes
src/types/account/index.ts Outdated Show resolved Hide resolved
nubsthead
nubsthead previously approved these changes Jun 28, 2024
View reviewed changes
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 37.30% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 37.30% Coverage (62.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (5.20% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

beawar
beawar reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are there. Just clean up the Mods type, since it has remained dirty from initial changes.

src/types/network/index.ts Outdated Show resolved Hide resolved
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 37.30% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 37.30% Coverage (62.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (5.20% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@nubsthead nubsthead self-requested a review June 28, 2024 15:43
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 37.30% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 37.30% Coverage (62.70% Estimated after merge)
  • Duplications 0.00% Duplicated Code (5.20% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@beawar beawar merged commit f9d04d8 into devel Jul 1, 2024
2 of 3 checks passed
@beawar beawar deleted the SHELL-226-Expose-a-function-to-update-settings-store branch July 1, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarto mbarto mbarto left review comments

@nubsthead nubsthead nubsthead approved these changes

@beawar beawar beawar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gnekoz @CLAassistant @mbarto @beawar @nubsthead @matteobaglini