Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose upsertApp api #421

Merged
merged 6 commits into from
May 21, 2024
Merged

feat: expose upsertApp api #421

merged 6 commits into from
May 21, 2024

Conversation

CataldoMazzilli
Copy link
Member

Refs: SHELL-199

@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 1 New Issues (is greater than 0)

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 0.00% Coverage (61.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 1 New Issues (is greater than 0)

Analysis Details

1 Issue

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 1 Code Smell

Coverage and Duplications

  • Coverage 0.00% Coverage (61.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@CataldoMazzilli CataldoMazzilli marked this pull request as ready for review May 16, 2024 13:02
@CataldoMazzilli CataldoMazzilli requested review from a team as code owners May 16, 2024 13:02
beawar
beawar reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function is not exposed to apps nor in the library

gnekoz
gnekoz previously approved these changes May 17, 2024
View reviewed changes
@CataldoMazzilli CataldoMazzilli requested a review from beawar May 20, 2024 09:46
@sonarqube-zextras Sonarqube Zextras
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (61.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@CataldoMazzilli CataldoMazzilli requested a review from gnekoz May 20, 2024 09:46
beawar
beawar previously approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add an example of usage. It could be a jsdoc or a comment in the PR itself, or a section in the internal documentation.

rodleyorosa
rodleyorosa previously approved these changes May 21, 2024
View reviewed changes
@beawar
docs: document upsertApp
23ee144 
Refs: SHELL-199
@beawar beawar dismissed stale reviews from rodleyorosa and themself via 23ee144 May 21, 2024 08:48
@beawar beawar requested review from rodleyorosa and beawar May 21, 2024 08:48
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (63.10% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

1 similar comment
@sonarqube-zextras Sonarqube Zextras
Copy link

Failed

  • 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 0.00% Coverage (63.10% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.60% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@CataldoMazzilli CataldoMazzilli merged commit b2e454a into devel May 21, 2024
2 of 3 checks passed
@CataldoMazzilli CataldoMazzilli deleted the SHELL-199-Improve-app-version-settings-to-show-only-what-each-module-wants-to-show branch May 21, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rodleyorosa rodleyorosa rodleyorosa approved these changes

@beawar beawar beawar approved these changes

@gnekoz gnekoz Awaiting requested review from gnekoz

Assignees

@CataldoMazzilli CataldoMazzilli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CataldoMazzilli @gnekoz @beawar @rodleyorosa