Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove incomplete delegates management #419

Conversation

gnekoz
Copy link
Contributor

@gnekoz gnekoz commented May 3, 2024

  • Removed the Delegates component, and all the related code, from the account settings page
  • Removed the Delegates component file
  • Updated the AccountsSettings component tests

Refs: SHELL-214

@gnekoz gnekoz requested review from a team as code owners May 3, 2024 16:29
@gnekoz gnekoz marked this pull request as draft May 3, 2024 16:31
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (61.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.80% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (61.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.80% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@gnekoz gnekoz marked this pull request as ready for review May 7, 2024 09:18
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (61.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.80% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

1 similar comment
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (61.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.80% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

beawar
beawar previously approved these changes May 15, 2024
nubsthead
nubsthead previously approved these changes May 20, 2024
@beawar beawar self-requested a review May 20, 2024 12:44
@CataldoMazzilli
Copy link
Member

Also src/mocks/handlers/getRightsRequest.ts can be removed now (also the usage in src/mocks/handlers.ts )

@beawar
Copy link
Contributor

beawar commented Jun 6, 2024

@gnekoz do you need some help with this?

@gnekoz gnekoz dismissed stale reviews from nubsthead and beawar via 425338d June 6, 2024 16:46
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (62.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.80% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@beawar
Copy link
Contributor

beawar commented Jun 11, 2024

ping @gnekoz

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (62.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (6.80% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@CataldoMazzilli CataldoMazzilli merged commit 44072bb into devel Jun 12, 2024
3 checks passed
@CataldoMazzilli CataldoMazzilli deleted the SHELL-214-Remove-delegation-buttons-and-setting-from-the-Account-Settings branch June 12, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants