fix: module boards can trigger mousedown events

[nubsthead]

Refs: SHELL-175

[sonarqube-zextras]

• 1 New Issues (is greater than 0)

Analysis Details

1 Issue

• 0 Bugs
• 0 Vulnerabilities
• 1 Code Smell

Coverage and Duplications

• 100.00% Coverage (60.00% Estimated after merge)
• 0.00% Duplicated Code (6.10% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

[beawar]

I went through the history of the move and even if in the original requirement the move was to make it trigger from the entire board, in the same first implementation it emerged that only the header bar was actually triggering the move, since it was the only component outside the app-board content.

We should ask for a validation round, specific for the move, but for the rest the changes look good to me 🚀

[nubsthead]

I went through the history of the move and even if in the original requirement the move was to make it trigger from the entire board, in the same first implementation it emerged that only the header bar was actually triggering the move, since it was the only component outside the app-board content.

We should ask for a validation round, specific for the move, but for the rest the changes look good to me 🚀

Do you want me to ask for a validation for this specific PR?

[beawar]

Do you want me to ask for a validation for this specific PR?

@nubsthead yeah I would feel safer to specify to the validator that the move action is now fully restricted to the header component, even if this should not change anything on the user side.

[nubsthead]

Do you want me to ask for a validation for this specific PR?

@nubsthead yeah I would feel safer to specify to the validator that the move action is now fully restricted to the header component, even if this should not change anything on the user side.

@beawar The fact is I restricted it to the header just to keep the same behaviour it already has. It can be enabled to the entire board moving back the moveHandler function on its previous component. I moved it to avoid changing its current behaviour.

However I will ask a validation to make sure it is what they expected