Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent overwriting display of main route if focus mode is true #382

Merged
merged 4 commits into from
Feb 27, 2024
Merged

fix: prevent overwriting display of main route if focus mode is true #382

merged 4 commits into from
Feb 27, 2024

Conversation

rodleyorosa
Copy link
Contributor

Refs: SHELL-188

@rodleyorosa rodleyorosa self-assigned this Feb 26, 2024
@rodleyorosa rodleyorosa requested review from a team as code owners February 26, 2024 11:43
lisaparma
lisaparma previously approved these changes Feb 26, 2024
View reviewed changes
gnekoz
gnekoz previously approved these changes Feb 26, 2024
View reviewed changes
@rodleyorosa rodleyorosa dismissed stale reviews from gnekoz and lisaparma via 5635b45 February 27, 2024 08:49
@rodleyorosa
test: apply review hints
8cd2787 
Refs: SHELL-188
beawar
beawar approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened SHELL-199 for a related problem when registering multiple routes for the same module (not in focus mode). We prefer treating this one as a separate issue since it requires some reasoning on it

@rodleyorosa
Merge branch 'devel' into SHELL-188-wrong-app-name-on-application-ver…
b202db4 
…sion-section-if-add-route-is-called-more-than-once
@rodleyorosa rodleyorosa merged commit f0cb48f into devel Feb 27, 2024
2 checks passed
@rodleyorosa rodleyorosa deleted the SHELL-188-wrong-app-name-on-application-version-section-if-add-route-is-called-more-than-once branch February 27, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisaparma lisaparma lisaparma approved these changes

@CataldoMazzilli CataldoMazzilli CataldoMazzilli approved these changes

@beawar beawar beawar approved these changes

@gnekoz gnekoz gnekoz left review comments

@nubsthead nubsthead Awaiting requested review from nubsthead nubsthead is a code owner automatically assigned from zextras/crabonions

@AliceTincani AliceTincani Awaiting requested review from AliceTincani AliceTincani is a code owner automatically assigned from zextras/crabonions

@giuliano176 giuliano176 Awaiting requested review from giuliano176 giuliano176 is a code owner automatically assigned from zextras/crabonions

Assignees

@rodleyorosa rodleyorosa

Labels
validated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rodleyorosa @gnekoz @beawar @CataldoMazzilli @lisaparma @eugeniamuff