fix: improve accountStore update inside account setting onSave #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CataldoMazzilli
requested review from
dhavaldodiya,
nubsthead and
AlessioCrestani
lisaparma
previously approved these changes
Oct 23, 2023
…-is-not-updated-when-saved-from-account-settings
CerDennis
previously approved these changes
Oct 23, 2023
beawar
reviewed
Oct 23, 2023
Co-authored-by: Beatrice Guerra <[email protected]>
CataldoMazzilli
dismissed stale reviews from CerDennis and lisaparma
via
4409490
lisaparma
approved these changes
Oct 23, 2023
beawar
approved these changes
Oct 23, 2023
CataldoMazzilli
deleted the
SHELL-176-New-persona-from-name-input-field-is-not-updated-when-saved-from-account-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: SHELL-176