Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discard changes of timezone, locale and dark mode reset initial … #346

Merged
merged 3 commits into from
Oct 23, 2023
Merged

fix: discard changes of timezone, locale and dark mode reset initial … #346

merged 3 commits into from
Oct 23, 2023

Conversation

CataldoMazzilli
Copy link
Member

…values

refs: SHELL-161

@CataldoMazzilli CataldoMazzilli requested review from a team as code owners October 17, 2023 10:52
@CataldoMazzilli CataldoMazzilli self-assigned this Oct 17, 2023
nubsthead
nubsthead previously approved these changes Oct 20, 2023
View reviewed changes
beawar
beawar reviewed Oct 20, 2023
View reviewed changes
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discard and save buttons remain enabled also when, after changing some selection, I reset everything to the previous situation.
I've checked on account settings and I think we never defined how the UI should behave in this situation, because some settings are disabling the buttons once the user set everything as it was, some others are leaving the buttons enabled. I feel we need to establish a single common behavior

src/settings/language-and-timezone-settings.tsx Show resolved Hide resolved
src/settings/language-and-timezone-settings.tsx Show resolved Hide resolved
src/settings/language-and-timezone-settings.tsx Outdated Show resolved Hide resolved
@CataldoMazzilli
Merge remote-tracking branch 'origin/devel' into SHELL-161-Discard-in…
0aa99f5 
…side-settings-does-not-reset-values-to-previous-one
@CataldoMazzilli
Copy link
Member Author

Discard and save buttons remain enabled also when, after changing some selection, I reset everything to the previous situation. I've checked on account settings and I think we never defined how the UI should behave in this situation, because some settings are disabling the buttons once the user set everything as it was, some others are leaving the buttons enabled. I feel we need to establish a single common behavior

ok created specific issue

@CataldoMazzilli CataldoMazzilli merged commit 0b1abed into devel Oct 23, 2023
@CataldoMazzilli CataldoMazzilli deleted the SHELL-161-Discard-inside-settings-does-not-reset-values-to-previous-one branch October 23, 2023 12:23
giuliano176 pushed a commit that referenced this pull request Dec 4, 2023
@CataldoMazzilli @giuliano176
fix: discard changes of timezone, locale and dark mode reset initial …
027e05e 
…values

refs: SHELL-161 (#346)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nubsthead nubsthead nubsthead approved these changes

@beawar beawar beawar approved these changes

@gnekoz gnekoz Awaiting requested review from gnekoz gnekoz is a code owner automatically assigned from zextras/crabonions

@eugeniamuff eugeniamuff Awaiting requested review from eugeniamuff eugeniamuff is a code owner automatically assigned from zextras/crabonions

@MatteoPerdon MatteoPerdon Awaiting requested review from MatteoPerdon MatteoPerdon is a code owner automatically assigned from zextras/crabonions

Assignees

@CataldoMazzilli CataldoMazzilli

Labels
validated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CataldoMazzilli @beawar @nubsthead @eugeniamuff