-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix out of office setting #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs: SHELL-101
CataldoMazzilli
requested review from
dhavaldodiya,
eugeniamuff and
MatteoPerdon
June 22, 2023 08:41
beawar
reviewed
Jun 22, 2023
src/settings/components/account-settings/settings-sent-messages.tsx
Outdated
Show resolved
Hide resolved
beawar
reviewed
Jun 22, 2023
beawar
reviewed
Jun 22, 2023
Co-authored-by: Beatrice Guerra <[email protected]>
Co-authored-by: Beatrice Guerra <[email protected]>
refs: SHELL-101
beawar
reviewed
Jun 29, 2023
Co-authored-by: Beatrice Guerra <[email protected]>
Co-authored-by: Beatrice Guerra <[email protected]>
Co-authored-by: Beatrice Guerra <[email protected]>
beawar
reviewed
Jun 29, 2023
beawar
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can consider this finished (it is already enormously out of scope from the initial issue).
All the not-fixed problems not related to this PR have now a specific issue or an open point of discussion inside SHELL-116.
nubsthead
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed all usage of xmlSoapFetch in shell project to avoid encoding-problems with "<>&" characters
deprecated usage of editSetting and removed usage in shell
refs: SHELL-101