Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix out of office setting #268

Merged
merged 12 commits into from
Jul 4, 2023
Merged

Conversation

CataldoMazzilli
Copy link
Member

@CataldoMazzilli CataldoMazzilli commented Jun 22, 2023

removed all usage of xmlSoapFetch in shell project to avoid encoding-problems with "<>&" characters
deprecated usage of editSetting and removed usage in shell

refs: SHELL-101

src/settings/components/account-settings/accounts-list.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.tsx Show resolved Hide resolved
src/settings/accounts-settings.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.tsx Outdated Show resolved Hide resolved
src/settings/general-settings.tsx Show resolved Hide resolved
types/account/index.d.ts Outdated Show resolved Hide resolved
types/network/index.d.ts Outdated Show resolved Hide resolved
types/network/index.d.ts Outdated Show resolved Hide resolved
types/network/index.d.ts Outdated Show resolved Hide resolved
types/network/index.d.ts Show resolved Hide resolved
@CataldoMazzilli CataldoMazzilli requested a review from beawar June 26, 2023 14:42
@CataldoMazzilli CataldoMazzilli self-assigned this Jun 29, 2023
src/settings/accounts-settings.test.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.test.tsx Outdated Show resolved Hide resolved
src/settings/accounts-settings.test.tsx Show resolved Hide resolved
src/settings/accounts-settings.test.tsx Show resolved Hide resolved
src/settings/accounts-settings.test.tsx Outdated Show resolved Hide resolved
@CataldoMazzilli CataldoMazzilli requested a review from beawar June 29, 2023 14:27
src/settings/accounts-settings.tsx Outdated Show resolved Hide resolved
src/settings/general-settings.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can consider this finished (it is already enormously out of scope from the initial issue).
All the not-fixed problems not related to this PR have now a specific issue or an open point of discussion inside SHELL-116.

@beawar beawar merged commit 42e757e into devel Jul 4, 2023
@beawar beawar deleted the SHELL-101-out-of-office-not-working branch July 4, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants