Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): fix UI of out of office section #263

Merged
merged 14 commits into from
Jun 20, 2023
Merged

fix(settings): fix UI of out of office section #263

merged 14 commits into from
Jun 20, 2023

Conversation

beawar
Copy link
Contributor

@beawar beawar commented Jun 13, 2023 •
edited
Loading

  • refactor: replace external DateTimePicker with DS one
  • fix: remove create appointment section
    It's not working and is not creating an appointment.
    Created ZIF-554 for reintroducing this feature.
  • fix: make discard changes work in search settings

refs: SHELL-70 SHELL-51 ZIF-554 SHELL-32

beawar added 6 commits June 13, 2023 10:54
@beawar
fix(settings): fix UI of out of office section
97d679a 
Reset values to initial ones on discard

refs: SHELL-70
@beawar
fix: improve types for account prefs and add tests
4325b2c 
refs: SHELL-70
@beawar
fix: fix out of office time period section and remove create appointm…
3ef3bfc 
…ent UI

Remove create appointment section since it's not working and is not creating
an appoinment. Created ZIF-554 for reintroducing this feature.

refs: SHELL-70 ZIF-554
@beawar
refactor(settings): replace external DateTimePicker with DS one
05bfd07 
refs: SHELL-51
@beawar
fix: update out-of-office dates when time period is unchecked
d75e309 
* build(deps): cleanup deps duplicated in declaration because peerDeps

refs: SHELL-70
@beawar
fix: set date prefs if time period is checked
fc22457 
refs: SHELL-70
@beawar
Copy link
Contributor Author

beawar commented Jun 13, 2023 •
edited by CataldoMazzilli
Loading

@beawar beawar marked this pull request as ready for review June 15, 2023 13:55
@beawar beawar requested review from a team as code owners June 15, 2023 13:55
gnekoz
gnekoz previously approved these changes Jun 20, 2023
View reviewed changes
nubsthead
nubsthead previously approved these changes Jun 20, 2023
View reviewed changes
@beawar beawar dismissed stale reviews from nubsthead, CataldoMazzilli, and gnekoz via 1a38faa June 20, 2023 09:54
@beawar beawar requested a review from gnekoz June 20, 2023 10:04
@beawar beawar merged commit 2d5d44d into devel Jun 20, 2023
@beawar beawar deleted the SHELL-70-fix-out-of-office-settings-ui branch June 20, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nubsthead nubsthead nubsthead approved these changes

@CerDennis CerDennis CerDennis approved these changes

@CataldoMazzilli CataldoMazzilli CataldoMazzilli approved these changes

@AliceTincani AliceTincani Awaiting requested review from AliceTincani AliceTincani is a code owner automatically assigned from zextras/crabonions

@eugeniamuff eugeniamuff Awaiting requested review from eugeniamuff eugeniamuff is a code owner automatically assigned from zextras/crabonions

@MatteoPerdon MatteoPerdon Awaiting requested review from MatteoPerdon MatteoPerdon is a code owner automatically assigned from zextras/crabonions

@gnekoz gnekoz Awaiting requested review from gnekoz

Assignees
No one assigned
Labels
validated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@beawar @gnekoz @CataldoMazzilli @CerDennis @nubsthead @eugeniamuff