fix: remove click in favor of onClick #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix types. Extract callbacks and memoize them. Clean up the repo from the unused old files. refs: SHELL-67
CataldoMazzilli
previously approved these changes
Mar 30, 2023
nubsthead
previously approved these changes
Apr 4, 2023
beawar
requested review from
a team,
eugeniamuff and
MatteoPerdon
and removed request for
dhavaldodiya,
CataldoMazzilli,
FrancescoGottardi,
nubsthead,
a team,
eugeniamuff and
MatteoPerdon
CataldoMazzilli
previously approved these changes
Apr 11, 2023
lisaparma
previously approved these changes
Apr 11, 2023
nubsthead
previously approved these changes
Apr 14, 2023
beawar
dismissed stale reviews from nubsthead, lisaparma, and CataldoMazzilli
via
788c76c
beawar
requested review from
CataldoMazzilli,
nubsthead,
lisaparma,
a team,
dhavaldodiya,
MatteoPerdon and
AliceTincani
and removed request for
a team,
dhavaldodiya,
MatteoPerdon and
AliceTincani
nubsthead
approved these changes
Apr 20, 2023
gnekoz
approved these changes
Apr 20, 2023
CataldoMazzilli
approved these changes
Apr 24, 2023
lisaparma
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix types.
Extract callbacks and memoize them.
Clean up the repo from the unused old files.
refs: SHELL-67